Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Prepare release Instrumentation.ServiceFabricRemoting-1.9.0-beta.1 #2444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

opentelemetrybot
Copy link
Collaborator

Note: This PR was opened automatically by the prepare release workflow.

Release request: #2443
Requested by: @sablancoleis

Changes

  • CHANGELOG files updated for projects being released.

Commands

/UpdateReleaseDates: Use to update release dates in CHANGELOGs before merging [approvers, maintainers]
/CreateReleaseTag: Use after merging to push the release tag and trigger the job to create packages and push to NuGet [approvers, maintainers]

@opentelemetrybot opentelemetrybot added the release Related to the release process label Dec 20, 2024
@opentelemetrybot opentelemetrybot requested a review from a team as a code owner December 20, 2024 22:27
@github-actions github-actions bot added the comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting label Dec 20, 2024
@sablancoleis
Copy link
Contributor

@CodeBlanch , @Kielek could you please review this release request when you get a chance?

@CodeBlanch
Copy link
Member

@sablancoleis Is there some reason you are doing 1.9.0-beta.1 and not 1.10.0-beta.1? All the current stuff is on 1.10.0. I see the project is targeting 1.9.0 versions of things but we could fix that first. Basically what I want to know is if you have some specific need for 1.9.0 or not?

@sablancoleis
Copy link
Contributor

@sablancoleis Is there some reason you are doing 1.9.0-beta.1 and not 1.10.0-beta.1? All the current stuff is on 1.10.0. I see the project is targeting 1.9.0 versions of things but we could fix that first. Basically what I want to know is if you have some specific need for 1.9.0 or not?

@CodeBlanch , my team has been using this code in our applications for 3 months with OpenTelemetry and GenevaExporter 1.9.0, without any issues. We are not ready to upgrade to 1.10.0 yet and I would like to switch to use this nuget before upgrading to 1.10.0. @Kielek already mentioned in my other PR that he was ok with doing a couple of releases targeting 1.9.0 before moving to 1.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting release Related to the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants