Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin collector image in e2e tests #1441

Open
MrAlias opened this issue Dec 17, 2024 · 3 comments
Open

Pin collector image in e2e tests #1441

MrAlias opened this issue Dec 17, 2024 · 3 comments
Assignees
@MrAlias
Milestone
v0.20.0-alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Dec 17, 2024 •
edited
Loading

We currently use the latest collector image for our testing:

opentelemetry-go-instrumentation/.github/workflows/e2e/k8s/collector-helm-values.yml

Line 31 in d447af1

tag: "latest"

This means any breaking changes to the image will be introduced to our CI system without review (e.g. https://github.com/open-telemetry/opentelemetry-go-instrumentation/actions/runs/12377825359/job/34549117158?pr=1431)

We need to pin this image. We also need to ensure that renovate can help in the upgrade process.
@MrAlias MrAlias added the help wanted Extra attention is needed label Dec 17, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 17, 2024

Related to open-telemetry/opentelemetry-collector-releases#783

MrAlias added a commit to MrAlias/opentelemetry-go-instrumentation that referenced this issue Dec 17, 2024
@MrAlias
Pin opentelemetry-collector-contrib to 0.115.1
adc5443 
Part of open-telemetry#1441
@MrAlias MrAlias mentioned this issue Dec 17, 2024
Merged
@MrAlias MrAlias self-assigned this Dec 17, 2024
@MrAlias MrAlias removed the help wanted Extra attention is needed label Dec 17, 2024
@MrAlias MrAlias added this to the v0.20.0-alpha milestone Dec 17, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 17, 2024

#1443 provides a temporary fix. We still need to develop a solution that will allow renovate to update the collector image version.

Likely, this means wrapping the collector image in our own Dockerfile.

MrAlias added a commit that referenced this issue Dec 17, 2024
@MrAlias
Pin opentelemetry-collector-contrib to 0.115.1 (#1443)
03ee1f0 
* Pin opentelemetry-collector-contrib to 0.115.1

Part of #1441

* Update kafka-go/collector-helm-values.yml
@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 18, 2024

#1443 provides a temporary fix. We still need to develop a solution that will allow renovate to update the collector image version.

Likely, this means wrapping the collector image in our own Dockerfile.

Possible solution would be to follow what is planned here: https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1140/files#diff-292d6d00bcf2d0d55e146ba46e229366f0ed73fcb0ac11c4885a029f014161bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
None yet
Milestone
v0.20.0-alpha
Development

No branches or pull requests
1 participant
@MrAlias