Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ExtendedTextMapGetter in instrumentations #12868

Open
jamesmoessis opened this issue Dec 10, 2024 · 1 comment
Open

Implement ExtendedTextMapGetter in instrumentations #12868

jamesmoessis opened this issue Dec 10, 2024 · 1 comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@jamesmoessis
Copy link
Contributor

jamesmoessis commented Dec 10, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Spec has recently changed to specify extraction of multiple values for a given key: open-telemetry/opentelemetry-specification#4295

The Java SDK has added ExtendedTextMapGetter to handle this: open-telemetry/opentelemetry-java#6852 (when stabilised this extension may become a default method on TextMapGetter which should be then implemented by instrumentations).

Describe the solution you'd like

For instrumentations that have carriers that support multiple values for a single key (most HTTP implementations) this should be a relatively straightforward change.

It does not necessarily need to be supported by all instrumentations.
@jamesmoessis jamesmoessis added enhancement New feature or request needs triage New issue that requires triage labels Dec 10, 2024
@trask trask added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome and removed needs triage New issue that requires triage labels Dec 10, 2024
@xiepuhuan
Copy link
Contributor

xiepuhuan commented Dec 23, 2024 •
edited
Loading

I have gone through all the instrumentations and found that the following 15 TextMapGetter need to be modified. Can I make all the changes to TextMapGetter in single PR?
@trask

  • io.opentelemetry.instrumentation.grpc.v1_6.GrpcRequestGetter
  • io.opentelemetry.javaagent.instrumentation.grizzly.HttpRequestHeadersGetter
  • io.opentelemetry.instrumentation.spring.webmvc.v6_0.JakartaHttpServletRequestGetter
  • io.opentelemetry.instrumentation.spring.webmvc.v5_3.JavaxHttpServletRequestGetter
  • io.opentelemetry.javaagent.instrumentation.jetty.v12_0.Jetty12TextMapGetter
  • io.opentelemetry.instrumentation.kafka.internal.KafkaConsumerRecordGetter
  • io.opentelemetry.javaagent.instrumentation.liberty.dispatcher.LibertyDispatcherRequestGetter
  • io.opentelemetry.instrumentation.awssdk.v2_2.internal.SqsParentContext.MessageAttributeValueMapGetter
  • io.opentelemetry.javaagent.instrumentation.netty.v3_8.server.NettyHeadersGetter
  • io.opentelemetry.instrumentation.ratpack.v1_7.internal.RatpackGetter
  • io.opentelemetry.instrumentation.restlet.v1_1.internal.RestletHeadersGetter
  • io.opentelemetry.instrumentation.restlet.v2_0.internal.RestletHeadersGetter
  • io.opentelemetry.javaagent.instrumentation.servlet.ServletRequestGetter
  • io.opentelemetry.javaagent.instrumentation.undertow.UndertowExchangeGetter
  • io.opentelemetry.instrumentation.spring.webflux.v5_3.WebfluxTextMapGetter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trask @xiepuhuan @jamesmoessis