Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all latestDepTestLibrary versions that have an upper limit #749

Open
trask opened this issue Jul 22, 2020 · 0 comments · May be fixed by #12945
Open

Review all latestDepTestLibrary versions that have an upper limit #749

trask opened this issue Jul 22, 2020 · 0 comments · May be fixed by #12945

Comments

@trask
Copy link
Member

trask commented Jul 22, 2020

latestDepTestLibrary implicitly uses the latest version available in maven central, e.g.

But sometimes we have to apply an upper limit for one reason or another.

E.g.

latestDepTestLibrary group: 'org.elasticsearch.client', name: 'transport', version: '5.+'

where the upper limit is needed because we have separate instrumentation for 6.0.

And

latestDepTestLibrary group: 'io.lettuce', name: 'lettuce-core', version: '5.+'

where the upper limit is needed in order to avoid an alpha version 6.0.0.M1.

And sometimes the upper limit is needed because we haven't fixed the tests or the instrumentation to run on the latest version.

It would be good to review all of these upper limits, and try to categorize these upper limits:

  • Upper limit due to multi-versioned instrumentation
  • Upper limit due to latest version being alpha (and don't want to deal with alpha API churn)
  • Upper limit that should to be lifted

and decide on a plan for how to manage these going forward so the upper limit are not forgotten about.

@trask trask changed the title Review all latestDepTest versions that have a cap Review all latestDepTestLibraryversions that have a cap Sep 29, 2020
@trask trask changed the title Review all latestDepTestLibraryversions that have a cap Review all latestDepTestLibrary versions that have a cap Sep 29, 2020
@trask trask changed the title Review all latestDepTestLibrary versions that have a cap Review all latestDepTestLibrary versions that have an upper limit Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants