Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdownlint checking fails with upgrade to 0.37.x #5767

Open
chalin opened this issue Dec 11, 2024 · 3 comments
Open

Markdownlint checking fails with upgrade to 0.37.x #5767

chalin opened this issue Dec 11, 2024 · 3 comments
Labels
CI/infra CI & infrastructure dependencies Pull requests that update a dependency file

Comments

@chalin
Copy link
Contributor

chalin commented Dec 11, 2024

Upgrading markdownlint to 0.37.0 causes the following error:

$ npm run check:markdown
...

(node:7278) ExperimentalWarning: CommonJS module /Users/chalin/git/lf/open-telemetry/opentelemetry.io/gulp-src/lint-md.js is loading ES Module /Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/markdownlint/lib/exports.mjs using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
[18:43:38] Using gulpfile ~/git/lf/open-telemetry/opentelemetry.io/gulpfile.js
[18:43:38] Starting 'lint-md'...
[18:43:38] 'lint-md' errored after 25 ms
[18:43:38] TypeError: markdownlint is not a function
    at Transform.markdownLintFile [as _transform] (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/gulp-src/lint-md.js:45:3)
    at Transform._read (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:166:10)
    at Transform._write (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:155:83)
    at doWrite (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:390:139)
    at writeOrBuffer (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:381:5)
    at Writable.write (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:302:11)
    at Transform.ondata (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:629:20)
    at Transform.emit (node:events:524:28)
    at Transform.emit (node:domain:552:15)
    at addChunk (/Users/chalin/git/lf/open-telemetry/opentelemetry.io/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:279:12)
@chalin chalin added the CI/infra CI & infrastructure label Dec 11, 2024
@chalin chalin added the dependencies Pull requests that update a dependency file label Dec 12, 2024
@chalin
Copy link
Contributor Author

chalin commented Dec 18, 2024

@trask @dyladan @svrnm - any idea, off the top, of how to most easily/quickly fix this. I haven't investigated yet, but have a hunch (and a hope) that it shouldn't be too hard to fix 🤞

@trask
Copy link
Member

trask commented Dec 19, 2024

looks related to the recent changes in https://github.com/DavidAnson/markdownlint/blob/main/example/gulpfile.cjs

@trask
Copy link
Member

trask commented Dec 20, 2024

in case it helps in this repo: open-telemetry/semantic-conventions#1706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure dependencies Pull requests that update a dependency file
Projects
Status: No status
Development

No branches or pull requests

2 participants