-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamodb attributes are in aws namespace instead db #186
Comments
I think it's kind of a wash. All aws-API-specific attributes start with |
This was closed by mistake by the stale bot. Re-opening |
fyi @trask |
I'd vote for the |
even if we aren't targeting dynamodb as part of initial database semconv stability, I think we should make this change as part of the initial database semconv stability process so that this breaking change could benefit from being grouped with the other breaking changes related to stabilization |
I thought about this some more and changed my opinion. we should try to stick with the philosophy "try to consolidate all breaking changes into a single bump when going stable" and so we should defer this change until we are planing dynamodb semconv stabilization (which is not included as part of initial db semconv stability) |
The span attributes for dynamodb are currently in
aws
namespace.Other databases like mondodb or mssql have their special attributes in the
db
namespace.At other places like
cloud.region
vendor namespaces are also replaced/avoided by a generic namespace.Should the dynamodb attributes moved to db namespace?
The text was updated successfully, but these errors were encountered: