Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.server.active_requests to http.server.current_requests? #202

Open
trask opened this issue Jul 21, 2023 · 5 comments
Open

Rename http.server.active_requests to http.server.current_requests? #202

trask opened this issue Jul 21, 2023 · 5 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Jul 21, 2023

It would be nice to have a consistent approach to naming for "current number of X" / "number of active X" metrics

I think "current" might work more broadly/consistently because e.g. "active connections" could sound like connections which are being actively used, as opposed to the number of current connections in a connection pool.

@trask
Copy link
Member Author

trask commented Jul 25, 2023

Not many similar metrics, only found:

  • process.runtime.jvm.classes.current_loaded

@trask
Copy link
Member Author

trask commented Jul 25, 2023

Some options if we want to come up with a consistent rule:

  • http.server.request.current / jvm.class.current
  • http.server.request.active / jvm.class.active
    • I don't think .active works as broadly as .current
  • http.server.request.count / jvm.class.count
    • PRO - this aligns with other UpDownCounters which are captured as .count
    • CON - http.server.request.count sounds a bit like a (monotonic) counter

EDITED 10/28 to reflect #267

@lmolkova
Copy link
Contributor

lmolkova commented Jul 26, 2023

Another reason against active_* when applied to connections is that connection can go idle, while staying open. It's weird to have idle connection in active_connections counter. Current works better as a general term here too.

@trask
Copy link
Member Author

trask commented Oct 28, 2023

This metric is not (currently) in our initial stability plan, but I'm wondering now if it should be, so that this breaking change can be covered by the OTEL_SEMCONV_STABILITY_OPT_IN flag.

Nevermind, I think the naming convention here is still unclear. It would be good to have consistency across:

  • jvm.thread.count
  • jvm.class.count
  • http.server.current_requests

which ties into #211 and #260 (comment).

@trask trask moved this to Blocker for stability in Spec: HTTP Semantic Conventions Oct 28, 2023
@trask trask moved this from Blocker for stability to Can be addressed after stability in Spec: HTTP Semantic Conventions Oct 28, 2023
@github-actions github-actions bot added the Stale label Feb 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
@github-project-automation github-project-automation bot moved this from Can be addressed after stability to Done in Spec: HTTP Semantic Conventions Feb 26, 2024
@joaopgrassi joaopgrassi removed the Stale label Feb 26, 2024
@joaopgrassi
Copy link
Member

This was closed by mistake by the stale bot. Re-opening

@joaopgrassi joaopgrassi reopened this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

4 participants