Skip to content

Commit

Permalink
fix: Description tooltip in Global Configurations
Browse files Browse the repository at this point in the history
Due to a bug in getTooltip, the tooltips were never shown. This change
shows the tooltip when there is a description for the configuration option.
  • Loading branch information
rhopman authored and adamsaghy committed Nov 28, 2024
1 parent a27bd72 commit 1aed445
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<ng-container matColumnDef="name">
<th mat-header-cell *matHeaderCellDef mat-sort-header> {{'labels.inputs.name' | translate}} </th>
<td mat-cell *matCellDef="let configuration"> {{ configuration.name }}&nbsp;&nbsp;
<fa-icon icon="question-circle" matTooltip="{{ getTooltip(configuration.description) | translate }}" matTooltipPosition="right"></fa-icon>
<fa-icon *ngIf="configuration.description" icon="question-circle" matTooltip="{{ configuration.description | translate }}" matTooltipPosition="right"></fa-icon>
</td>
</ng-container>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,4 @@ export class GlobalConfigurationsTabComponent implements OnInit, AfterViewInit {
this.router.navigate(['/system']);
}

getTooltip(description: string): string {
if (description === undefined) {
return description;
}
return 'labels.text.No Description';
}

}

0 comments on commit 1aed445

Please sign in to comment.