fix: Loan Product missed labels

openMF · Jul 24, 2024 · 2f8854b · 2f8854b
1 parent 7800d67
commit 2f8854b
Show file tree

Hide file tree

Showing 18 changed files with 35 additions and 4 deletions.
diff --git a/...pp/products/loan-products/common/loan-product-summary/loan-product-summary.component.html b/...pp/products/loan-products/common/loan-product-summary/loan-product-summary.component.html
@@ -373,7 +373,7 @@ <h3 class="mat-h3" fxFlexFill>{{ 'labels.inputs.Loan Schedule' | translate}}</h3
   </div>
 
   <div fxFlexFill *ngIf="isAdvancedPaymentAllocation && supportedInterestRefundTypes.length > 0">
-    <span fxFlex="47%">{{ 'labels.inputs.SUPPORTED INTEREST REFUND TYPES' | translate}}:</span>
+    <span fxFlex="47%">{{ 'labels.inputs.Supported Interest Refund Types' | translate}}:</span>
     <span  fxFlex="53%">
       {{mapHumanReadableValueStringEnumOptionDataList(supportedInterestRefundTypes)}}
     </span>

diff --git a/src/app/products/loan-products/create-loan-product/create-loan-product.component.ts b/src/app/products/loan-products/create-loan-product/create-loan-product.component.ts
@@ -164,6 +164,9 @@ export class CreateLoanProductComponent implements OnInit {
   }
 
   mapStringEnumOptionToIdList(incomingValues: StringEnumOptionData[]): string[] {
+    if (!incomingValues) {
+      return [];
+    }
     return incomingValues.map(v => v.id);
   }
 }
diff --git a/...tepper/loan-product-interest-refund-step/loan-product-interest-refund-step.component.html b/...tepper/loan-product-interest-refund-step/loan-product-interest-refund-step.component.html
@@ -3,10 +3,10 @@
   <div fxLayout="row wrap" fxLayoutGap="2%" fxLayout.lt-md="column">
 
     <mat-form-field fxFlex="48%">
-      <mat-label>{{'labels.inputs.SUPPORTED INTEREST REFUND TYPES' | translate}}</mat-label>
+      <mat-label>{{'labels.inputs.Supported Interest Refund Types' | translate}}</mat-label>
       <mat-select multiple formControlName="supportedInterestRefundTypes" matTooltip="{{ 'tooltips.Refund transactions where interest refund will automatically be calculated' | translate}}">
         <mat-option *ngFor="let supportedTransaction of supportedInterestRefundTypesOptions" [value]="supportedTransaction.id">
-          {{ supportedTransaction.value }}
+          {{ supportedTransaction.value | translateKey:'catalogs' }}
         </mat-option>
       </mat-select>
     </mat-form-field>

diff --git a/...-stepper/loan-product-interest-refund-step/loan-product-interest-refund-step.component.ts b/...-stepper/loan-product-interest-refund-step/loan-product-interest-refund-step.component.ts
@@ -45,6 +45,9 @@ export class LoanProductInterestRefundStepComponent implements OnInit {
   }
 
   mapStringEnumOptionToIdList(incomingValues: StringEnumOptionData[]): string[] {
+    if (!incomingValues) {
+      return [];
+    }
     return incomingValues.map(v => v.id);
   }
 

diff --git a/...pper/loan-product-payment-strategy-step/loan-product-payment-strategy-step.component.html b/...pper/loan-product-payment-strategy-step/loan-product-payment-strategy-step.component.html
@@ -24,7 +24,7 @@
     <mat-tab disabled>
         <ng-template mat-tab-label>
             <button mat-icon-button (click)="addTransaction()">
-                <mat-icon>{{ 'labels.buttons.Add' | translate}}</mat-icon>
+                <mat-icon><fa-icon icon="plus" size="sm"></fa-icon></mat-icon>
             </button>
         </ng-template>
     </mat-tab>

diff --git a/src/assets/styles/_colours.scss b/src/assets/styles/_colours.scss
@@ -65,6 +65,7 @@ $accent: $peter-river;
 //Status Colors Defined Here
 $status-active: #5cb85c;
 $status-inactive: #666f73;
+$status-paid: #666f73;
 $status-deleted: #000000;
 $status-pending: #ffa500;
 $status-approved: #4461e2;

diff --git a/src/assets/translations/cs-CS.json b/src/assets/translations/cs-CS.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Vybrat vklad",
       "Re-Invest Maturity Amount": "Částka splatnosti znovu investovat",
       "Re-Invest Principal Only": "Pouze reinvestice jistiny",
+      "Interest Refund": "Vrácení úroků",
       "Transfer to Savings": "Převod do Úspory"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Povolit zálohové platby",
       "valid": "platný",
       "INTEREST REFUND": "VRÁCENÍ ÚROKU",
+      "Supported Interest Refund Types": "Unterstützte Zinsrückerstattungsarten",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Podporované typy vrácení úroků"
     },
     "links": {

diff --git a/src/assets/translations/de-DE.json b/src/assets/translations/de-DE.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Einzahlung abheben",
       "Re-Invest Maturity Amount": "Fälligkeitsbetrag reinvestieren",
       "Re-Invest Principal Only": "Nur Kapital reinvestieren",
+      "Interest Refund": "Zinsrückerstattung",
       "Transfer to Savings": "Übertragen auf Ersparnisse"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Anzahlungen aktivieren",
       "valid": "gültig",
       "INTEREST REFUND": "ZINSRÜCKERSTATTUNG",
+      "Supported Interest Refund Types": "Unterstützte Zinsrückerstattungsarten",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Unterstützte Zinsrückerstattungsarten"
     },
     "links": {

diff --git a/src/assets/translations/en-US.json b/src/assets/translations/en-US.json
@@ -714,6 +714,7 @@
             "Withdraw Deposit": "Withdraw Deposit",
             "Re-Invest Maturity Amount": "Re-Invest Maturity Amount",
             "Re-Invest Principal Only": "Re-Invest Principal Only",
+            "Interest Refund": "Interest Refund",
             "Transfer to Savings": "Transfer to Savings"
         },
         "commons": {
@@ -2391,6 +2392,7 @@
             "Enable Down Payments": "Enable Down Payments",
             "valid": "valid",
             "INTEREST REFUND": "INTEREST REFUND",
+            "Supported Interest Refund Types": "Supported Interest Refund Types",
             "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Supported interest refund types"
         },
         "links": {

diff --git a/src/assets/translations/es-MX.json b/src/assets/translations/es-MX.json
@@ -711,6 +711,7 @@
             "Withdraw Deposit": "Retirar depósito",
             "Re-Invest Maturity Amount": "Reinvertir el monto al vencimiento",
             "Re-Invest Principal Only": "Reinvertir solo el capital",
+            "Interest Refund": "Reembolso de intereses",
             "Transfer to Savings": "Transferir a Ahorros"
         },
         "commons": {
@@ -2389,6 +2390,7 @@
             "Enable Down Payments": "Habilitar Pagos Iniciales",
             "valid": "válido",
           "INTEREST REFUND": "REEMBOLSO DE INTERESES",
+          "Supported Interest Refund Types": "Tipos de reembolso de intereses admitidos",
           "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Tipos de reembolso de intereses admitidos"
         },
         "links": {

diff --git a/src/assets/translations/fr-FR.json b/src/assets/translations/fr-FR.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Retirer un dépôt",
       "Re-Invest Maturity Amount": "Réinvestir le montant à l’échéance",
       "Re-Invest Principal Only": "Réinvestir le capital uniquement",
+      "Interest Refund": "Remboursement des intérêts",
       "Transfer to Savings": "Transfert vers l'épargne"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Activer les acomptes",
       "valid": "valide",
       "INTEREST REFUND": "REMBOURSEMENT DES INTÉRÊTS",
+      "Supported Interest Refund Types": "Types de remboursement d'intérêts pris en charge",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Types de remboursement d'intérêts pris en charge"
     },
     "links": {

diff --git a/src/assets/translations/it-IT.json b/src/assets/translations/it-IT.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Prelevare il deposito",
       "Re-Invest Maturity Amount": "Reinvestimento dell'importo a scadenza",
       "Re-Invest Principal Only": "Reinvestire solo il capitale",
+      "Interest Refund": "Rimborso degli interessi",
       "Transfer to Savings": "Trasferimento al risparmio"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Abilita acconti",
       "valid": "valido",
       "INTEREST REFUND": "RIMBORSO DEGLI INTERESSI",
+      "Supported Interest Refund Types": "Tipi di rimborso degli interessi supportati",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Tipi di rimborso degli interessi supportati"
     },
     "links": {

diff --git a/src/assets/translations/ko-KO.json b/src/assets/translations/ko-KO.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "예치금 인출",
       "Re-Invest Maturity Amount": "만기금액 재투자",
       "Re-Invest Principal Only": "본인만 재투자",
+      "Interest Refund": "이자환급",
       "Transfer to Savings": "저축으로 이체"
     },
     "commons": {
@@ -2391,6 +2392,7 @@
       "Enable Down Payments": "계약금 활성화",
       "valid": "유효한",
       "INTEREST REFUND": "이자환급",
+      "Supported Interest Refund Types": "지원되는 이자 환불 유형",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "지원되는 이자 환불 유형"
     },
     "links": {

diff --git a/src/assets/translations/lt-LT.json b/src/assets/translations/lt-LT.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Išsiimti indėlį",
       "Re-Invest Maturity Amount": "Iš naujo investuokite termino sumą",
       "Re-Invest Principal Only": "Iš naujo investuokite tik pagrindinę sumą",
+      "Interest Refund": "Palūkanų grąžinimas",
       "Transfer to Savings": "Perkėlimas į santaupas"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Įgalinti pradinius mokėjimus",
       "valid": "galioja",
       "INTEREST REFUND": "PALŪKANŲ GRĄŽINIMAS",
+      "Supported Interest Refund Types": "Palaikomi palūkanų grąžinimo tipai",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Palaikomi palūkanų grąžinimo tipai"
     },
     "links": {

diff --git a/src/assets/translations/lv-LV.json b/src/assets/translations/lv-LV.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Izņemt depozītu",
       "Re-Invest Maturity Amount": "Atkārtoti ieguldīt termiņa summu",
       "Re-Invest Principal Only": "Reinvestēt tikai pamatsummu",
+      "Interest Refund": "Procentu atmaksa",
       "Transfer to Savings": "Pārskaitījums uz uzkrājumiem"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Iespējot pirmās iemaksas",
       "valid": "derīgs",
       "INTEREST REFUND": "PROCENTU ATMAKSĀŠANA",
+      "Supported Interest Refund Types": "Atbalstītie procentu atmaksas veidi",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Atbalstītie procentu atmaksas veidi"
     },
     "links": {

diff --git a/src/assets/translations/ne-NE.json b/src/assets/translations/ne-NE.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "निक्षेप फिर्ता लिनुहोस्",
       "Re-Invest Maturity Amount": "परिपक्वता रकम पुन: लगानी गर्नुहोस्",
       "Re-Invest Principal Only": "पुन: लगानी प्रिन्सिपल मात्र",
+      "Interest Refund": "ब्याज फिर्ता",
       "Transfer to Savings": "बचतमा स्थानान्तरण गर्नुहोस्"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "डाउन पेमेन्टहरू सक्षम गर्नुहोस्",
       "valid": "मान्य",
       "INTEREST REFUND": "व्याज परतावा",
+      "Supported Interest Refund Types": "समर्थित ब्याज फिर्ता प्रकारहरू",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "समर्थित व्याज परतावा प्रकार"
     },
     "links": {

diff --git a/src/assets/translations/pt-PT.json b/src/assets/translations/pt-PT.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Retirar Depósito",
       "Re-Invest Maturity Amount": "Reinvestir o valor do vencimento",
       "Re-Invest Principal Only": "Reinvestir apenas o principal",
+      "Interest Refund": "Reembolso de juros",
       "Transfer to Savings": "Transferência para Poupança"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Habilitar adiantamentos",
       "valid": "válido",
       "INTEREST REFUND": "REEMBOLSO DE JUROS",
+      "Supported Interest Refund Types": "Tipos de reembolso de juros suportados",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Tipos de reembolso de juros suportados"
     },
     "links": {

diff --git a/src/assets/translations/sw-SW.json b/src/assets/translations/sw-SW.json
@@ -712,6 +712,7 @@
       "Withdraw Deposit": "Toa Amana",
       "Re-Invest Maturity Amount": "Wekeza Tena Kiasi cha Ukomavu",
       "Re-Invest Principal Only": "Wekeza tena Mkuu Pekee",
+      "Interest Refund": "Urejeshaji wa riba",
       "Transfer to Savings": "Hamisha kwa Akiba"
     },
     "commons": {
@@ -2390,6 +2391,7 @@
       "Enable Down Payments": "Washa Malipo ya Chini",
       "valid": "halali",
       "INTEREST REFUND": "MAREJESHO YA RIBA",
+      "Supported Interest Refund Types": "Aina za Urejeshaji wa Riba Zinazotumika",
       "SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND": "Aina za kurejesha riba zinazotumika"
     },
     "links": {