Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-1861 Temporarily hide fund mapping till the feature is complete #1863

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

Onyx2406
Copy link
Contributor

@Onyx2406 Onyx2406 commented Sep 10, 2023

Description

Temporarily hides fund mapping till the feature is complete A conditional Angular directive (*ngIf="!shouldShowFundMapping") is used to hide the "Fund Mapping" section based on the shouldShowFundMapping variable.

Related issues and discussion

#1861

Screenshots, if any

image

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Updated organization.component.html
@adamsaghy
Copy link
Collaborator

@Onyx2406 Please rebase with the latest and kindly check why the build is failing.

@Onyx2406
Copy link
Contributor Author

@adamsaghy

Copy link
Collaborator

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kindly review my questions!

angular.json Outdated Show resolved Hide resolved
src/environments/.env.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 44e52f9 into openMF:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants