Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Description tooltip in Global Configurations #2196

Merged

Conversation

rhopman
Copy link
Contributor

@rhopman rhopman commented Nov 15, 2024

Description

Due to a bug in getTooltip, the tooltips were never shown. This change shows the tooltip when there is a description for the configuration option. If there's no description, the icon is not displayed (rather than showing 'No description', which adds litte value in my opinion).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@adamsaghy
Copy link
Collaborator

@rhopman Please rebase based on latest

Due to a bug in getTooltip, the tooltips were never shown. This change
shows the tooltip when there is a description for the configuration option.
@rhopman rhopman force-pushed the fix-global-configuration-tooltips branch from 4273066 to 452018a Compare November 28, 2024 17:13
@rhopman
Copy link
Contributor Author

rhopman commented Nov 28, 2024

@rhopman Please rebase based on latest

Done.

@adamsaghy adamsaghy merged commit 1aed445 into openMF:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants