diff --git a/assets/main.js b/assets/main.js index 2443cf9fd..494c5d6d8 100644 --- a/assets/main.js +++ b/assets/main.js @@ -93,11 +93,12 @@ window.cavil = { createApp(RecentReviews).mount('#recent-reviews'); }, - setupReportMetadata(pkgId, hasManagerRole, hasAdminRole) { + setupReportMetadata(pkgId, hasManagerRole, hasAdminRole, hasLawyerRole) { const app = createApp(ReportMetadata); app.config.globalProperties.pkgId = pkgId; app.config.globalProperties.hasManagerRole = hasManagerRole; app.config.globalProperties.hasAdminRole = hasAdminRole; + app.config.globalProperties.hasLawyerRole = hasLawyerRole; app.mount('#report-metadata'); }, diff --git a/assets/vue/ReportMetadata.vue b/assets/vue/ReportMetadata.vue index 7117580c6..1d953cdb8 100644 --- a/assets/vue/ReportMetadata.vue +++ b/assets/vue/ReportMetadata.vue @@ -273,7 +273,9 @@
  -   + +   +
diff --git a/docs/Architecture.md b/docs/Architecture.md index 83179ba22..fafb9399e 100644 --- a/docs/Architecture.md +++ b/docs/Architecture.md @@ -95,11 +95,11 @@ Legal reports can be in one of four states: * `new`: Initial state, report ready for review. -* `acceptable`: Reviewed and accepted by a human expert, no in-dept review has been performed however. +* `acceptable`: Reviewed and accepted by a human expert, but not a lawyer. -* `correct`: In-depth review by a lawyer that resulted in accepting the report. +* `correct`: Review by a lawyer that resulted in accepting the report. -* `rejected`: In-depth review by a lawyer that resulted in rejecting the report. +* `rejected`: Review by a lawyer that resulted in rejecting the report. ### UI diff --git a/templates/reviewer/details.html.ep b/templates/reviewer/details.html.ep index 858d56a63..ad6b415cd 100644 --- a/templates/reviewer/details.html.ep +++ b/templates/reviewer/details.html.ep @@ -6,7 +6,8 @@ % content_for 'ready_function' => begin % my $has_manager_role = current_user_has_role('manager') ? 'true' : 'false'; % my $has_admin_role = current_user_has_role('admin') ? 'true' : 'false'; - cavil.setupReportMetadata(<%= $id %>, <%= $has_manager_role %> ,<%= $has_admin_role %>); + % my $has_lawyer_role = current_user_has_role('lawyer') ? 'true' : 'false'; + cavil.setupReportMetadata(<%= $id %>, <%= $has_manager_role %> ,<%= $has_admin_role %>, <%= $has_lawyer_role %>); % end % my $raw_license = $spec->{main}{license};