feat: add form_post response mode support for Apple OAuth #85
+48
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Extend OAuth2 adapter to support form_post response mode - Add POST callback handler for form data - Include first-time user info in tokenset - Make form_post support generic for other providers Fixes #82 Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
🦋 Changeset detectedLatest commit: 6661578 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: [email protected] <[email protected]>
…/openauthjs/openauth into devin/1734404382-apple-form-post
|
this PR isn't required simply modify query and it'll work apple: AppleOidcAdapter({
clientID: Resource.AppleAppId.value,
query: {
response_mode: "form_post",
response_type: "code id_token",
},
scopes: ["email", "name"],
}),
``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for form_post response mode in the OAuth2 adapter, required by Apple sign-in.
Changes:
Fixes #82
Link to Devin run: https://app.devin.ai/sessions/644d0dad073949e1af4a56c0819bc68a