OAuth User Data Should be included in the success value object

[SOG-web]

I want to suggest we add some basic user info on the oauth provider

at least most people would need the user email, name, id, firstname and lastname

This will make it more easy to adopt for oauth, if anybody is having a more advance use case they can always use the tokens to do that

@thdxr

[SOG-web]

Also I think there is an error with scopes, only one of the scope in the array is getting picked

github: GithubAdapter({
      clientID: process.env.GITHUB_CLIENT_ID!,
      clientSecret: process.env.GITHUB_CLIENT_SECRET!,
      scopes: ["user:email", "profile"],
    }),
    ```

Response of oauth (value.tokenset.raw)
```ts
{
  access_token: "gggg",
  token_type: "bearer",
  scope: "user:email",
}

[SOG-web]

Am using this currently

} else if (value.provider === "github") {
      const githubUserResponse = await fetch("https://api.github.com/user", {
        headers: {
          Authorization: `Bearer ${value.tokenset.access}`,
        },
      });


      const githubUser: GitHubUser = await githubUserResponse.json();
      }
      

Doing this for all oauth provider will be very tedious since all I need is the email and the name from any oauth provider

or we could just dump the data on value.extra, so from there anyone can pick what they need

[Cmion]

This might be tricky tho, since we may need to account for each scopes. For instance do we want to get the user's full profile with

const response = await fetch("https://api.github.com/user", {
	headers: {
		Authorization: `Bearer ${value.tokenset.access}`
	}
});
const user = await response.json();

or just their emails with scope(user:email)

const response = await fetch("https://api.github.com/user/emails", {
	headers: {
		Authorization: `Bearer ${value.tokenset.access}`
	}
});
const emails = await response.json();

[SOG-web]

This might be tricky tho, since we may need to account for each scopes. For instance do we want to get the user's full profile with

const response = await fetch("https://api.github.com/user", {
	headers: {
		Authorization: `Bearer ${value.tokenset.access}`
	}
});
const user = await response.json();

or just their emails with scope(user:email)

const response = await fetch("https://api.github.com/user/emails", {
	headers: {
		Authorization: `Bearer ${value.tokenset.access}`
	}
});
const emails = await response.json();

I think just getting the user profile should be enough for most use casess

[SteakFisher]

Wouldn't forwarding along the access tokens returned by each provider as part of the subjects object suffice?

[thdxr]

the challenge here is there is no consistent spec for just oauth2 to get userinfo - there is for those who implement OIDC

i think having to add a fetch in your success handler is a bit annoying but ultimately not a big deal so would probably just ask people to do that instead of assuming what you want to do

[SOG-web]

the challenge here is there is no consistent spec for just oauth2 to get userinfo - there is for those who implement OIDC

i think having to add a fetch in your success handler is a bit annoying but ultimately not a big deal so would probably just ask people to do that instead of assuming what you want to do

Hmm, I get you know. What if i create a package that does just the fetching of the user profile then maybe we can just give an optional way for people to inject it into the oauth process instead of doing it on success.

That will make it more cleaner

[SOG-web]

Also I think there is way the go community are handling it, I can do a little digging

Because on go side the user profile is been returned for all the oauth providers they support