Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: Warning: Oem.OpenBmc.Certificates not defined in schema OemManager #117

Open
gtmills opened this issue Feb 20, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@gtmills
Copy link
Member

gtmills commented Feb 20, 2020

From the validator:
WARNING - Oem.OpenBmc.Certificates not defined in schema OemManager (check version, spelling and casing)

https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/managers.hpp#L1627

  "Oem": {
    "@odata.context": "/redfish/v1/$metadata#OemManager.Oem",
    "@odata.id": "/redfish/v1/Managers/bmc#/Oem",
    "@odata.type": "#OemManager.Oem",
    "OpenBmc": {
      "@odata.context": "/redfish/v1/$metadata#OemManager.OpenBmc",
      "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc",
      "@odata.type": "#OemManager.OpenBmc",
      "Certificates": {
        "@odata.id": "/redfish/v1/Managers/bmc/Truststore/Certificates"
      }

But don't see Certificates defined in the OemManager schema.
https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/schema/OemManager_v1.xml
https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/JsonSchemas/OemManager/index.json

@feistjj
Copy link
Member

feistjj commented Feb 20, 2020

cfcd5f6 introduced this issue, @devenrao can you please fix this issue?

+        oemOpenbmc["Certificates"] = {
+            {"@odata.id", "/redfish/v1/Managers/bmc/Truststore/Certificates"}};

@devenrao
Copy link
Contributor

cfcd5f6 introduced this issue, @devenrao can you please fix this issue?

+        oemOpenbmc["Certificates"] = {
+            {"@odata.id", "/redfish/v1/Managers/bmc/Truststore/Certificates"}};

sure will take a look

@edtanous
Copy link
Contributor

Can this be closed?

@edtanous edtanous added the bug Something isn't working label Oct 19, 2020
@gtmills
Copy link
Member Author

gtmills commented Oct 19, 2020

This is still an issue.
at Managers/bmc I see

 "Oem": {
    "@odata.context": "/redfish/v1/$metadata#OemManager.Oem",
    "@odata.id": "/redfish/v1/Managers/bmc#/Oem",
    "@odata.type": "#OemManager.Oem",
    "OpenBmc": {
      "@odata.context": "/redfish/v1/$metadata#OemManager.OpenBmc",
      "@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc",
      "@odata.type": "#OemManager.OpenBmc",
      "Certificates": {
        "@odata.id": "/redfish/v1/Managers/bmc/Truststore/Certificates"
      }
    }
  },

but nothing in https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/schema/OemManager_v1.xml for certificates. @devenrao Can you have a look?

@matthewfischer
Copy link

This has since been renamed to OpenBMCManaged by commit fc1cdd1

I am not sure if the issue still exists or not.

@gtmills
Copy link
Member Author

gtmills commented Dec 21, 2024

Still a problem

### /redfish/v1/Managers/bmc/Truststore/Certificates/

But /redfish/v1/Managers/$managerId/Truststore/Certificates isn't an allowed location
https://redfish.dmtf.org/schemas/v1/Certificate_v1.xml

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/61958 was an attempt to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants