Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add implementation of giving it live pv data #47

Closed
wants to merge 4 commits into from
Closed

add implementation of giving it live pv data #47

wants to merge 4 commits into from

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Feb 6, 2024 •
edited by aryanbhosale
Loading

Pull Request

Description

  • Add live pv data to v1 model
  • added an example
    TODO - run this with evaluation, perhaps with 1 hour of live pv data

Fixes #36

How Has This Been Tested?

Added an example and TODO run evaluation

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (760bfd6) to head (a20a240).
Report is 158 commits behind head on main.

❗ Current head a20a240 differs from pull request most recent head d7f8300

Please upload reports for the commit d7f8300 to get more accurate results.

Files Patch % Lines
quartz_solar_forecast/data.py 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           main      #47       +/-   ##
=========================================
+ Coverage      0   79.87%   +79.87%     
=========================================
  Files         0       11       +11     
  Lines         0      333      +333     
=========================================
+ Hits          0      266      +266     
- Misses        0       67       +67

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield marked this pull request as draft February 15, 2024 12:31
@aryanbhosale
Copy link
Member

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

@aryanbhosale
Copy link
Member

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Can this be merged?

@peterdudfield
Copy link
Contributor Author

Yea, I let this sit there for a bit. I think what needs to happen is

  • resovle conficts
  • run (and update) evaluation code to see how much better the model is with this live PV data.

Do you fancy doing that @aryanbhosale

@peterdudfield
Copy link
Contributor Author

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Its realted to #66, but this mean users can enter their live PV data into the model. And yea, this could be done using the enphase API, or other methods.

Wanted to also run the evaluation to show how much better the model is by using this data

@aryanbhosale
Copy link
Member

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Its realted to #66, but this mean users can enter their live PV data into the model. And yea, this could be done using the enphase API, or other methods.

Wanted to also run the evaluation to show how much better the model is by using this data

Oh that's great, are there any changes needed here ?

@peterdudfield
Copy link
Contributor Author

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Its realted to #66, but this mean users can enter their live PV data into the model. And yea, this could be done using the enphase API, or other methods.
Wanted to also run the evaluation to show how much better the model is by using this data

Oh that's great, are there any changes needed here ?

Totally up to you. You could build off this branch, or start a fresh, totally up to you.

This was referenced Jun 4, 2024
Closed
Merged
@aryanbhosale
takes the current time instead of manually typing it out, and it also…
2e8e3c7 
… converts the data to float64 format by default in case the data is of type int64(just a small change to overcome errors in case they arise)
@aryanbhosale
revert changes
d7f8300
@aryanbhosale
Copy link
Member

Can this be closed @peterdudfield , since we've added live integration of 4 inverters

@peterdudfield peterdudfield deleted the issue/live-pv-data branch September 3, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to add live PV
2 participants
@peterdudfield @aryanbhosale