Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConditionalRequirements related to Manager EthernetInterfaceCollection for skipping logical instance like usb0 #78

Open
plmanik opened this issue May 27, 2024 · 3 comments

Comments

@plmanik
Copy link

plmanik commented May 27, 2024

Hi,
As per https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/blob/master/HWMgmt/OCPBaselineHardwareManagement.v1_1_0.json

HostName": {
	"ReadRequirement": "Recommended",
	"ConditionalRequirements": [{
		"SubordinateToResource": ["Manager", "EthernetInterfaceCollection"],
		"ReadRequirement": "Mandatory",
		"WriteRequirement": "Mandatory"
	}]

Based on ConditionalRequirements, WriteRequirement is verified for eth0(physical instance), usb0(Logical instance for Host interface communication between BMC and Host) in Manager ethernetinterface instance. In case of usb0(Logical instance for Host interface communication between BMC and Host) it's not required to support changing HostName, FQDN, IPv4Addresses#0, NameServers since it's going to be same as physical instance(eth0) in Manager resource.
Chances for some Physical instance also to restrict patch. Is it possible to skip WriteRequirement for logical interface by using use case or anyof comparison to make sure to change one instance in Manager ethernetinterface collection?

@mraineri @jautor Please add your inputs based on schema for skipping WriteRequirement for logical ethernetinterface instance like usb0 or we can accept patch on usb0, reflect the values in eth0, usb0

Thanks,
Mani

@jcleung5549
Copy link
Contributor

jcleung5549 commented Aug 8, 2024

Valid issue. Need to decide how to solve. Use Supported?

@plmanik
Copy link
Author

plmanik commented Sep 3, 2024

Can we use URIs to handle this situation

"EthernetInterface": {
            "ReadRequirement": "Mandatory",
            "URIs": [
                "/redfish/v1/Managers/{ManagerId}/EthernetInterfaces/{EthernetInterfaceId}"
            ],

Thanks,
Mani

@jcleung5549
Copy link
Contributor

The URI won't work because other NICs on the Manager also need to be tested. Decision to use "Supported".

Will also modify the Profile spec and/or model to handle this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants