Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making NotifyIPv6Scope, NotifyMulticastIntervalSeconds, NotifyTTL attributes as optional in SSDP object available in OCPBaselineHardwareManagement.v1_1_0.json #87

Open
plmanik opened this issue Sep 3, 2024 · 2 comments
Labels

Comments

@plmanik
Copy link

plmanik commented Sep 3, 2024

As per https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/blob/master/HWMgmt/OCPBaselineHardwareManagement.v1_1_0.json NotifyIPv6Scope, NotifyMulticastIntervalSeconds, NotifyTTL is required if SSDP attribute implemented

"SSDP": {
					"ReadRequirement": "Recommended",
					"PropertyRequirements": {
						"ProtocolEnabled": {},
						"Port": {},
						"NotifyMulticastIntervalSeconds": {},
						"NotifyIPv6Scope": {},
						"NotifyTTL": {}
					}
				}

Can we change NotifyIPv6Scope, NotifyMulticastIntervalSeconds, NotifyTTL as recommended/optional(Not mandatory to implement).

In https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/blob/master/HWMgmt/OCPBaselineRedfishService.v1_0_0.json ProtocolEnabled attribute is only mandatory and remaining attributes NotifyIPv6Scope, NotifyMulticastIntervalSeconds, NotifyTTL were optional

 "SSDP": {
                    "ReadRequirement": "Recommended",
                    "PropertyRequirements": {
                        "ProtocolEnabled": {
                            "ReadRequirement": "Mandatory",
                            "WriteRequirement": "Mandatory"
                        },
                        "Port": {},
                        "NotifyMulticastIntervalSeconds": {},
                        "NotifyIPv6Scope": {},
                        "NotifyTTL": {}
                    }
                }

Can we follow same approach in OCPBaselineHardwareManagement.v1_1_0.json

Thanks,
Mani

@jcleung5549
Copy link
Contributor

9/3 - Make the requirement IfImplemented for those properties.

jautor added a commit to jautor/OCP-Profiles that referenced this issue Sep 3, 2024
@plmanik
Copy link
Author

plmanik commented Sep 3, 2024

Thanks @jcleung5549 @jautor For immediate support. Can we add this change in OCPBaselineHardwareManagement.v1_1_0.json also? Are we going to maintain two profiles OCPBaselineHardwareManagement.v1_1_0.json, OCPBaselineRedfishService.v1_0_0.json for checking redfish service

Mani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants