Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor PLT-1.1 helper methods #3663

Open
dplore opened this issue Dec 19, 2024 · 1 comment
Open

refactor PLT-1.1 helper methods #3663

dplore opened this issue Dec 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dplore
Copy link
Member

dplore commented Dec 19, 2024

There should be a single _test.go file in a folder.

The base_test.go file is all helper methods. Please move the helper functions inside /internal. For example functions related to platform probably could go into a library that's already started at: internal/components/components.go. Similarly different location for IP address incrementing function (inside /internal)

@dplore dplore added the enhancement New feature or request label Dec 19, 2024
@dplore
Copy link
Member Author

dplore commented Dec 19, 2024

Also note I see this test README which heavily overlaps with PLT-1.1. This RT-8 test README should be removed

https://github.com/openconfig/featureprofiles/blob/main/feature/interface/singleton/singleton_with_breakouts/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant