Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix: sink ccx courses on original course published #78

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Feb 19, 2024

Description: This PR sinks the CCX child courses when the master course is published.

Testing instructions:

  1. Enable CCX courses
  2. Create a CCX course
  3. Publish the master course
  4. Verify that the CCX child courses are sink

Author concerns

Although there is a signal receiver for the course_published signal in the CCX Django application, this application has been written for the LMS, so the signal is never connected. Refactoring it would require a major development effort that's out of scope for this project. Also, doing that refactoring will not be compatible with older edx-platform releases.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 19, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ian2012 Ian2012 merged commit 5f3bd59 into main Feb 20, 2024
9 checks passed
@Ian2012 Ian2012 deleted the cag/ccx-support branch February 20, 2024 15:28
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants