Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not fixed quite yet #1

Open
brianfeister opened this issue Mar 29, 2017 · 2 comments
Open

Not fixed quite yet #1

brianfeister opened this issue Mar 29, 2017 · 2 comments

Comments

@brianfeister
Copy link
Member

brianfeister commented Mar 29, 2017

Just realized I fixed the "roll all dice at once to their explosion termination" issue, but didn't fix the other issue:
(pseudocode)

if ( total initial pool explosions > keeperDice ) {
  resultsArray.push( rolledDice.slice(0, keeperDice.length) );
}
@BuildAndDie
Copy link

Not sure if this is what you are referring to, but this was noticed about the roller:

If you select only 1 advantage for a d20, and that is all you roll (no attribute dice), you get results for all the multiples of 20. Because of explosions, there should not be a result of 20 at all.

If you roll just a d20 with no advantage/disadvantage, it does what you expect, giving no results for the multiples of 20.

By itself, that might mean it is just including the 20 and the explosion together, however:

If you roll JUST a d4 with advantage (0 d20), you end up getting results for a value of 4, but oddly, not for the higher values of 4 (8, 12, 16, etc). Not really sure what is going on , but wanted to point it out to you.

@brianfeister
Copy link
Member Author

brianfeister commented May 5, 2017

@BuildAndDie from my pseudo-code, I would say "yes, I think that's what I meant when I wrote this".... I've got bigger fish to fry now and will worry about this later. Realistically, I might do a "Statgen" thing that's more official and I'd probably remove the random factor and just do a static map of the known values so as not to blow up people's computers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants