Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Data Flow: Optimize FlowGraph Creation #21

Open
JLLeitschuh opened this issue Jul 14, 2023 · 1 comment
Open

Global Data Flow: Optimize FlowGraph Creation #21

JLLeitschuh opened this issue Jul 14, 2023 · 1 comment
Labels
enhancement New feature or request feature: Global Data Flow

Comments

@JLLeitschuh
Copy link
Collaborator

Currently, we are redundantly creating multiple FlowGraph for paths that we've already previously computed. We could optimize this by having a cache of DataFlowNode to FlowGraph, such that when we attempt to create a FlowGraph for an existing DataFlowNode, we return the existing FlowGraph.

This could likely further be optimized if, while performing the data flow computation, we received a cached FlowGraph could stop the computation preemptively.
@JLLeitschuh JLLeitschuh added the enhancement New feature or request label Jul 14, 2023
@JLLeitschuh JLLeitschuh changed the title Global Data Flow: Optimize FlowGraph Creation Global Data Flow: Optimize FlowGraph Creation Jul 14, 2023
@joanvr
Copy link

joanvr commented Jul 17, 2023

Thank you for your suggestion. Would you like this to be assigned to you? :)

@joanvr joanvr moved this to Backlog in OpenRewrite Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature: Global Data Flow
Projects
OpenRewrite
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joanvr @JLLeitschuh