org.openrewrite.java.migrate.UpgradeToJava17

[nddipiazza-ebay]

Issue with org.openrewrite.staticanalysis.AddSerialAnnotationToSerialVersionUID

As a result of addressing
openrewrite/rewrite-migrate-java#96

@Serial was added to any serialVersionUID field in Serializable classes.

But the import was forgotten resulting in

cannot find symbol
[ERROR]   symbol:   class Serial

[melloware]

Hmm can you provide a reproducer? I am seeing the imports get created in a couple of project I have run it on?

[timtebeek]

Would also help to know what version you're using, and indeed ideally as a failing unit test, as per this example.

rewrite-static-analysis/src/test/java/org/openrewrite/staticanalysis/AddSerialAnnotationToSerialVersionUIDTest.java

Lines 34 to 57 in 2163f0f

	@Test
	void addSerialAnnotation() {
	rewriteRun(
	//language=java
	java(
	"""
	import java.io.Serializable;
	class Example implements Serializable {
	private static final long serialVersionUID = 1L;
	}
	""",
	"""
	import java.io.Serial;
	import java.io.Serializable;
	class Example implements Serializable {
	@Serial
	private static final long serialVersionUID = 1L;
	}
	"""
	)
	);
	}

Adding the annotation is directly above adding the annotation, so I wouldn't expect any issue.

rewrite-static-analysis/src/main/java/org/openrewrite/staticanalysis/AddSerialAnnotationToSerialVersionUID.java

Lines 71 to 78 in 2163f0f

	if (isPrivateStaticFinalLongSerialVersionUID(vd) &&
	FindAnnotations.find(vd, "@java.io.Serial").isEmpty()) {
	maybeAddImport("java.io.Serial");
	return JavaTemplate.builder("@Serial")
	.imports("java.io.Serial")
	.build()
	.apply(getCursor(), vd.getCoordinates().addAnnotation(Comparator.comparing(J.Annotation::getSimpleName)));
	}

[nddipiazza-ebay]

mvn -U "org.openrewrite.maven:rewrite-maven-plugin:run" "-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:LATEST,org.openrewrite.recipe:rewrite-testing-frameworks:LATEST,org.openrewrite.recipe:rewrite-spring:LATEST" "-Drewrite.activeRecipes=org.openrewrite.java.spring.boot2.SpringBoot2JUnit4to5Migration,org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic,org.openrewrite.java.migrate.UpgradeToJava17,org.openrewrite.java.testing.mockito.ReplacePowerMockito,org.openrewrite.maven.RemoveDuplicateDependencies"

result:

[timtebeek]

That's odd; and what version of Java are you running when you invoke that mvn command above? I wonder if you'd see any improvements if you use Java 17 to run that command instead.