Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] publish core plugin ZIPs also to maven #16656

Open
rursprung opened this issue Nov 15, 2024 · 2 comments
Open

[Feature Request] publish core plugin ZIPs also to maven #16656

rursprung opened this issue Nov 15, 2024 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request Plugins

Comments

@rursprung
Copy link
Contributor

Is your feature request related to a problem? Please describe

our build system does not have access to the internet. we can however fetch resources via maven (local server which proxies the requests) and are using this to fetch other plugins. however, i just noticed that this does not apply to core plugins (e.g. the newly introduced analysis-phonenumber).

Describe the solution you'd like

core plugins should, like other plugins (e.g. the security plugin) have their ZIP files published to maven central, so that they can be fetched via maven.

Related component

Plugins

Describe alternatives you've considered

if the URL for downloading plugins is stable and documented (the latter at least isn't the case yet: opensearch-project/documentation-website#8763) it might be an option to configure the maven proxy to fetch files from there. we'd have to try that (it will also depend on the structure at the address where it has been published).

however, since the whole infrastructure for plugin ZIP publishing is in place in the opensearch ecosystem it'd probably be relatively easy to add the publishing step to the release?

Additional context

other plugin ZIPs are being published to maven since this issue has been implemented a while ago: opensearch-project/opensearch-build#1916

CC @reta & @saratvemulapalli with whom i had discussed this already a bit on slack

@rursprung rursprung added enhancement Enhancement or improvement to existing feature or request untriaged labels Nov 15, 2024
@reta
Copy link
Collaborator

reta commented Nov 15, 2024

(sharing the Slack discussion) I personally see no compelling reasons to publish core plugins to Maven repositories, because of the following:

  • any core plugin could be downloaded for offline use (the URLs are stable and will be documented [1])
  • the core plugins are in "preferred" position
    a) the tooling installs them by name (fe opensearch-pluging install transport-nio )
    b) they are signed and the signatures are verified

Although Maven layout may look convenient for OpenSearch core plugins (those are ZIPs btw), any single build tool available out there could be tailored to deal with offline dependencies.

[1] opensearch-project/documentation-website#8763

@dblock dblock removed the untriaged label Dec 9, 2024
@dblock
Copy link
Member

dblock commented Dec 9, 2024

[Catch All Triage - 1, 2, 3, 4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Plugins
Projects
None yet
Development

No branches or pull requests

3 participants