-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cluster and replication package debug logging for testSingleIndexShardAllocation test #11878
Conversation
Compatibility status:Checks if related components are compatible with change ebaa216 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git] |
❌ Gradle check result for 2686943: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…dexShardAllocation test Signed-off-by: Suraj Singh <[email protected]>
2686943
to
ebaa216
Compare
❌ Gradle check result for ebaa216: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11878 +/- ##
============================================
- Coverage 71.43% 71.39% -0.04%
+ Complexity 59407 59385 -22
============================================
Files 4921 4921
Lines 278989 278989
Branches 40543 40543
============================================
- Hits 199287 199176 -111
- Misses 63086 63212 +126
+ Partials 16616 16601 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a config to enable this in a particular cluster rather than globally enabling? Will this flood all the logs for all clusters? (Resolved)
Looks like a build is failing please fix |
Thanks @deshsidd for the review. The added TestLogging annotation should only impact the test which is annotated. |
@msfroh @peternied @dblock Maintainers approval required here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreamer-89 Thanks for making this change - can you help me see the new log messages that have been logged with this annotation? I don't see them gradle check log associated with the test, [link]
Thanks @peternied for the review. I think the log response was truncated in this case(not sure why). Though post failure, the test logs are added to gradle check console output.
|
@peternied @kotwanikunal : Request for review. |
…dexShardAllocation test (#11878) Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit f9ab801) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…dexShardAllocation test (#11878) (#12091) (cherry picked from commit f9ab801) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…dexShardAllocation test (opensearch-project#11878) Signed-off-by: Suraj Singh <[email protected]>
…dexShardAllocation test (opensearch-project#11878) Signed-off-by: Suraj Singh <[email protected]>
…dexShardAllocation test (opensearch-project#11878) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Coming from #11299, need to enable logs at cluster and replication level for debugging the cause of cluster heapth request timeout.
Related Issues
Related #11299
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.