Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle/maven CI checks for OpenSearch plugins that verify (the order of) maven repos #637

Open
dblock opened this issue Sep 28, 2021 · 1 comment
Labels
enhancement New Enhancement

Comments

@dblock
Copy link
Member

dblock commented Sep 28, 2021

Is your feature request related to a problem? Please describe

It's very easy to forget to keep mavenLocal in a repo's gradle/maven configuration, which prevents the bundle build from forcing a locally built OpenSearch, common-utils or job-scheduler dependency. For example, https://github.com/opensearch-project/index-management/pull/141/files#r717955366

Describe the solution you'd like

Add a check that lists maven repos that are being used and ensure the list is the one documented in https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md: mavenLocal(), mavenCentral(), then maven { url "https://aws.oss.sonatype.org/content/repositories/snapshots" }.

Describe alternatives you've considered

No response

Additional context

No response

@dblock dblock added enhancement New Enhancement untriaged Issues that have not yet been triaged v1.2.0 OpenSearch 1.2 version and removed untriaged Issues that have not yet been triaged labels Sep 28, 2021
@peternied peternied removed the v1.2.0 OpenSearch 1.2 version label Nov 16, 2021
@gaiksaya
Copy link
Member

Hi @dblock,

We did confirm same as an effort for opensearch-project/opensearch-devops#114
Do we want to add this check as a part of build process/ci check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants