[BUG] Remove reflection logic to call AdmissionControl plugin APIs #403
Labels
bug
Something isn't working
Comments
5 tasks
khushbr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the bug?
AdmissionControlCollector right now collects jvmmp/request_size metrics from AdmissionController plugin. It uses reflection to load static instances of those classes.
How can one reproduce the bug?
Its a code best practises bug.
What is the expected behavior?
performance-analyzer plugin should expose SPI with admissioncontrol methods. AdmissionController plugin should implement this SPI as well extending performance-analyzer plugin. performance-analyzer plugin should implement ExtensiblePlugin interface and so that it can load static admission controller objects from AdmissionController plugin.
The text was updated successfully, but these errors were encountered: