From 7570eeb2d1ad4cc4447f0b30841c8c13484892e2 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 26 Jun 2023 07:23:46 -0300 Subject: [PATCH 1/5] bgp: Using variable after free --- bgpd/bgp_bfd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bgpd/bgp_bfd.c b/bgpd/bgp_bfd.c index d1ddfd0460..23c6ee3587 100644 --- a/bgpd/bgp_bfd.c +++ b/bgpd/bgp_bfd.c @@ -320,8 +320,10 @@ static void bgp_peer_remove_bfd(struct peer *p) return; } - if (p->bfd_config) - bfd_sess_free(&p->bfd_config->session); + if (p->bfd_config) { + bfd_sess_free(&p->bfd_config->session); + p->bfd_config->manual = false; + } XFREE(MTYPE_BFD_CONFIG, p->bfd_config); } From 72b072356872938cc1e3ba8dafae40950c46cb07 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 26 Jun 2023 07:26:23 -0300 Subject: [PATCH 2/5] bgp: Using variable after free --- bgpd/bgp_bfd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bgpd/bgp_bfd.c b/bgpd/bgp_bfd.c index 23c6ee3587..21ee505cdb 100644 --- a/bgpd/bgp_bfd.c +++ b/bgpd/bgp_bfd.c @@ -320,10 +320,8 @@ static void bgp_peer_remove_bfd(struct peer *p) return; } - if (p->bfd_config) { + if (p->bfd_config) bfd_sess_free(&p->bfd_config->session); - p->bfd_config->manual = false; - } XFREE(MTYPE_BFD_CONFIG, p->bfd_config); } From 5277a3aa010112883dac7058358a65effbb87dfd Mon Sep 17 00:00:00 2001 From: Martin Winter Date: Thu, 7 Dec 2023 19:39:05 +0100 Subject: [PATCH 3/5] doc: Small doc change for CI test Signed-off-by: Martin Winter --- doc/developer/building-frr-for-freebsd13.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/developer/building-frr-for-freebsd13.rst b/doc/developer/building-frr-for-freebsd13.rst index 0bc8277930..5ee73ca9ab 100644 --- a/doc/developer/building-frr-for-freebsd13.rst +++ b/doc/developer/building-frr-for-freebsd13.rst @@ -1,4 +1,4 @@ -FreeBSD 13 +FreeBSD 13 and 12 ========== FreeBSD 13 restrictions: From 37dd03154280b1eec224c00435566d298bd8626d Mon Sep 17 00:00:00 2001 From: Martin Winter Date: Fri, 8 Dec 2023 10:52:13 +0100 Subject: [PATCH 4/5] doc: fix underlining --- doc/developer/building-frr-for-freebsd13.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/developer/building-frr-for-freebsd13.rst b/doc/developer/building-frr-for-freebsd13.rst index 5ee73ca9ab..41e9961e56 100644 --- a/doc/developer/building-frr-for-freebsd13.rst +++ b/doc/developer/building-frr-for-freebsd13.rst @@ -1,5 +1,5 @@ FreeBSD 13 and 12 -========== +================= FreeBSD 13 restrictions: ------------------------ From ba4016ac9174e2eb2dfffa0dea8c12aea205d03f Mon Sep 17 00:00:00 2001 From: Martin Winter Date: Fri, 8 Dec 2023 14:16:54 +0100 Subject: [PATCH 5/5] doc: include FreeBSD 14 as well Signed-off-by: Martin Winter --- doc/developer/building-frr-for-freebsd13.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/developer/building-frr-for-freebsd13.rst b/doc/developer/building-frr-for-freebsd13.rst index 41e9961e56..ec9792acc5 100644 --- a/doc/developer/building-frr-for-freebsd13.rst +++ b/doc/developer/building-frr-for-freebsd13.rst @@ -1,5 +1,5 @@ -FreeBSD 13 and 12 -================= +FreeBSD 13 and 12 and 14 +======================== FreeBSD 13 restrictions: ------------------------