Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uni04delta-ipv6] Add octavia #348

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

beagles
Copy link
Contributor

@beagles beagles commented Jul 30, 2024

Add service values and network configuration for octavia

Copy link

openshift-ci bot commented Jul 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: beagles
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9127c197614948cab63d062b38a4fb0f

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 4m 15s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 3m 33s

@beagles beagles force-pushed the uni04delta-ipv6-octavia branch from 25c42e3 to 9bda2ba Compare July 30, 2024 22:49
@beagles beagles force-pushed the uni04delta-ipv6-octavia branch from 9bda2ba to 094e1db Compare August 13, 2024 12:03
@beagles beagles marked this pull request as ready for review August 13, 2024 12:03
@beagles beagles added do-not-merge Changes are not ready to be merged do-not-merge/hold and removed do-not-merge Changes are not ready to be merged do-not-merge/hold labels Aug 13, 2024
@abays
Copy link
Contributor

abays commented Aug 19, 2024

Has anyone tested this?

@abays abays added the needs-testing Testing proof is required prior to merge label Aug 19, 2024
@fultonj
Copy link
Contributor

fultonj commented Aug 26, 2024

@beagles can you comment?

@fultonj
Copy link
Contributor

fultonj commented Sep 9, 2024

As per Brent this has not yet been tested so we will hold for now.

@fultonj
Copy link
Contributor

fultonj commented Sep 16, 2024

@lavraham is this something you'll be working on?

I'm asking since you had added octavia to alpha and eta.

#367
#335

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/004edf8de8734a73bb826c0267470f18

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 3m 52s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 3m 29s
✔️ rhoso-architecture-validate-uni07eta SUCCESS in 3m 51s

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/73a82f35d45440929659d3aaaf95eefe

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 3m 40s
rhoso-architecture-validate-uni04delta-ipv6 FAILURE in 4m 13s
✔️ rhoso-architecture-validate-uni07eta SUCCESS in 4m 45s

@beagles beagles force-pushed the uni04delta-ipv6-octavia branch from 67fa1f3 to c64a855 Compare October 28, 2024 13:09
Add service values and network configuration for octavia
adding octavia-ca-passphrase
@beagles beagles force-pushed the uni04delta-ipv6-octavia branch from c04a4be to da9546f Compare November 7, 2024 13:02
Copy link
Contributor

@sdatko sdatko Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My knowledge of Kustomizations is very limited, but I think the entries added in this file should go to dt/uni04delta-ipv6/control-plane/kustomization.yaml (note the extra control-plane/ directory)

I created another PR to change (permissions issue) based on @Shimi's comment 
openstack-k8s-operators#442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress do-not-merge Changes are not ready to be merged needs-testing Testing proof is required prior to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants