-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[delta-ipv6] Shared control plane vars #402
[delta-ipv6] Shared control plane vars #402
Conversation
There is two stage with control plane config, the shared options moved to a shared file which used by both stages.
@afazekas is this being done to address a bug? What about this is specific to delta-IPv6? |
delta-ipv6 has ironic enabled and the 2th definition of the control-plane otherwise undo the ironic config. |
+2 from me @hjensas are you ok with this? |
+2 from me as well, without this we ended up enabling ironic when initially deploying the controlplane, then disabling it post ceph deployment when the controlplane was re-configured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afazekas, fultonj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
please consider cherry picking as per https://github.com/openstack-k8s-operators/architecture/blob/main/docs/contributing/cherry-picking.md |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
ce8c86a
into
openstack-k8s-operators:18.0.0-proposed
There is two stage with control plane config,
the shared options moved to a shared file which
used by both stages.