Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[delta-ipv6] Shared control plane vars #402

Conversation

afazekas
Copy link
Contributor

There is two stage with control plane config,
the shared options moved to a shared file which
used by both stages.

There is two stage with control plane config,
the shared options moved to a shared file which
used by both stages.
@openshift-ci openshift-ci bot requested review from cjeanner and fultonj September 18, 2024 06:34
@fultonj
Copy link
Contributor

fultonj commented Sep 18, 2024

@afazekas is this being done to address a bug? What about this is specific to delta-IPv6?

@afazekas
Copy link
Contributor Author

delta-ipv6 has ironic enabled and the 2th definition of the control-plane otherwise undo the ironic config.

@fultonj
Copy link
Contributor

fultonj commented Sep 19, 2024

+2 from me

@hjensas are you ok with this?

@hjensas
Copy link
Contributor

hjensas commented Sep 19, 2024

+2 from me

@hjensas are you ok with this?

+2 from me as well, without this we ended up enabling ironic when initially deploying the controlplane, then disabling it post ceph deployment when the controlplane was re-configured.

Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afazekas, fultonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fultonj
Copy link
Contributor

fultonj commented Sep 19, 2024

@fultonj fultonj added the needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges label Sep 19, 2024
Copy link
Contributor

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ce8c86a into openstack-k8s-operators:18.0.0-proposed Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants