Use Ceph monitoring (not RGW) network for Dashboard #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the existing `cifmw_cephadm_monitoring_network` parameter to configure the Ceph dashboard instead of the `cifmw_cephadm_rgw_network` parameter. This was not detected earlier because the Ceph playbook set them both to the Ceph public_network, but we recently added a feature to run RGW on a separate network [1]. Also, add retries/delay to the dashboard HTTP check and mange if HTTPS should be used. [1] openstack-k8s-operators#2301 Jira: https://issues.redhat.com/browse/OSPCIX-506 (cherry-picked from f6e4645) Signed-off-by: John Fulton <[email protected]>
|
Thanks for the PR! ❤️ |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8a83e82
into
openstack-k8s-operators:18.0.0-proposed
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the existing
cifmw_cephadm_monitoring_networkparameter to configure the Ceph dashboard instead of thecifmw_cephadm_rgw_networkparameter. This was not detected earlier because the Ceph playbook set them both to the Ceph public_network, but we recently added a feature to run RGW on a separate network [1].Also, add retries/delay to the dashboard HTTP check and mange if HTTPS should be used.
[1] #2301
Jira: https://issues.redhat.com/browse/OSPCIX-506
(cherry-picked from f6e4645)