Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert addition of Swift network #2418

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Revert addition of Swift network #2418

merged 2 commits into from
Oct 2, 2024

Conversation

fultonj
Copy link
Contributor

@fultonj fultonj commented Oct 1, 2024

This PR reverts the following merged PRs:

For reasons documented in the Jira below we will not add the RGW network to va/hci.

Jira: https://issues.redhat.com/browse/OSPRH-10496

@github-actions github-actions bot marked this pull request as draft October 1, 2024 23:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@fultonj fultonj marked this pull request as ready for review October 1, 2024 23:34
@fultonj
Copy link
Contributor Author

fultonj commented Oct 1, 2024

I recommend merging openstack-k8s-operators/architecture#410 before this PR

@fultonj fultonj requested a review from abays October 1, 2024 23:42
This was referenced Oct 2, 2024
Merged
Closed
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2cef6e3c1f6e44138ac34a54c99a492b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 53s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 29s
❌ podified-multinode-hci-deployment-crc FAILURE in 25m 01s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 21s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 06s
✔️ build-push-container-cifmw-client SUCCESS in 21m 21s
❌ cifmw-molecule-ci_gen_kustomize_values FAILURE in 6m 36s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 5m 27s

@fmount
Copy link
Contributor

fmount commented Oct 2, 2024

recheck

@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 2, 2024
fmount
fmount approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dc04a3a into openstack-k8s-operators:main Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmount fmount fmount approved these changes

@hjensas hjensas Awaiting requested review from hjensas

@pablintino pablintino Awaiting requested review from pablintino pablintino is a code owner

@abays abays Awaiting requested review from abays

Assignees

@fmount fmount

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fultonj @fmount @pablintino