Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless log warnings in TracerAutoConfiguration #6

Open
Vity01 opened this issue Jan 24, 2019 · 6 comments
Open

Useless log warnings in TracerAutoConfiguration #6

Vity01 opened this issue Jan 24, 2019 · 6 comments

Comments

@Vity01
Copy link

Vity01 commented Jan 24, 2019

If I set opentracing.jaeger.enabled: false which is a standard way how to disable Jaeger in configuration then I get warnings like

Tracer bean is not configured! Switching to ...

Imho these warnings should be set to level DEBUG.

@geoand
Copy link
Collaborator

geoand commented Jan 24, 2019

If I set opentracing.jaeger.enabled: false which is a standard way how to disable Jaeger in configuration then I get warnings like

Tracer bean is not configured! Switching to ...

Imho these warnings should be set to level DEBUG.

Hey @Vity01

Can you please post the entire log line?
The reason I am asking is because I am pretty sure that this message isn't produced by this starter

@geoand
Copy link
Collaborator

geoand commented Jan 24, 2019

If I set opentracing.jaeger.enabled: false which is a standard way how to disable Jaeger in configuration then I get warnings like

Tracer bean is not configured! Switching to ...

Imho these warnings should be set to level DEBUG.

Hey @Vity01

Can you please post the entire log line?
The reason I am asking is because I am pretty sure that this message isn't produced by this starter

Oops, sorry about the message above, I though the issue was opened on the Jaeger starter :)

@geoand
Copy link
Collaborator

geoand commented Jan 24, 2019

I opened #7 to address this.
I have used info instead of warn - I believe info is more appropriate than debug

@Vity01
Copy link
Author

Vity01 commented Jan 24, 2019

Sorry, I should be more specific - I mean this line:

@Vity01
Copy link
Author

Vity01 commented Jan 24, 2019

Thank you for the pretty fast answer&change although I still think the DEBUG is more appropriate in this case.
In the Spring world you usually don't get messages about binded and/or not-binded beans at level INFO.
It's a quite common practice to declare default bean (NoOp in this case) if there is no other instance made by application.

@geoand
Copy link
Collaborator

geoand commented Jan 24, 2019

Thank you for the pretty fast answer&change although I still think the DEBUG is more appropriate in this case.
In the Spring world you usually don't get messages about binded and/or not-binded beans at level INFO.
It's a quite common practice to declare default bean (NoOp in this case) if there is no other instance made by application.

You have a point :). PR updated

@Vity01 Vity01 changed the title Useless log warnings in TracerAutoConfiguration for Useless log warnings in TracerAutoConfiguration Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants