From e4a6be5b1754c79574218ff760d21ca21da2aa9b Mon Sep 17 00:00:00 2001 From: Jason Sherman Date: Mon, 25 Sep 2023 11:07:14 -0700 Subject: [PATCH] add required method to base, remove unneeded methods from implementations Signed-off-by: Jason Sherman --- aries_cloudagent/anoncreds/base.py | 11 ++++++----- .../anoncreds/default/did_indy/registry.py | 8 +------- .../anoncreds/default/did_web/registry.py | 8 +------- 3 files changed, 8 insertions(+), 19 deletions(-) diff --git a/aries_cloudagent/anoncreds/base.py b/aries_cloudagent/anoncreds/base.py index 0fa530a194..19f8fe1690 100644 --- a/aries_cloudagent/anoncreds/base.py +++ b/aries_cloudagent/anoncreds/base.py @@ -1,6 +1,6 @@ """Base Registry.""" from abc import ABC, abstractmethod -from typing import Generic, Optional, Pattern, Sequence, Tuple, TypeVar +from typing import Generic, Optional, Pattern, Sequence, TypeVar from ..config.injection_context import InjectionContext from ..core.error import BaseError @@ -11,6 +11,7 @@ GetCredDefResult, ) from .models.anoncreds_revocation import ( + GetRevListResult, GetRevRegDefResult, RevRegDef, RevRegDefResult, @@ -130,10 +131,10 @@ async def get_revocation_registry_definition( """Get a revocation registry definition from the registry.""" @abstractmethod - async def get_revocation_registry_delta( - self, profile: Profile, rev_reg_def_id: str, timestamp: None - ) -> Tuple[dict, int]: - """Get a revocation registry delta.""" + async def get_revocation_list( + self, profile: Profile, revocation_registry_id: str, timestamp: int + ) -> GetRevListResult: + """Get a revocation list from the registry.""" class BaseAnonCredsRegistrar(BaseAnonCredsHandler): diff --git a/aries_cloudagent/anoncreds/default/did_indy/registry.py b/aries_cloudagent/anoncreds/default/did_indy/registry.py index 18a7796c2d..f15d6e2618 100644 --- a/aries_cloudagent/anoncreds/default/did_indy/registry.py +++ b/aries_cloudagent/anoncreds/default/did_indy/registry.py @@ -1,7 +1,7 @@ """DID Indy Registry.""" import logging import re -from typing import Optional, Pattern, Sequence, Tuple +from typing import Optional, Pattern, Sequence from ....config.injection_context import InjectionContext from ....core.profile import Profile @@ -98,12 +98,6 @@ async def get_revocation_list( """Get a revocation list from the registry.""" raise NotImplementedError() - async def get_revocation_registry_delta( - self, profile: Profile, rev_reg_def_id: str, timestamp: None - ) -> Tuple[dict, int]: - """Get a revocation registry delta.""" - raise NotImplementedError() - async def register_revocation_list( self, profile: Profile, diff --git a/aries_cloudagent/anoncreds/default/did_web/registry.py b/aries_cloudagent/anoncreds/default/did_web/registry.py index ccab7a8e97..98853f3c0c 100644 --- a/aries_cloudagent/anoncreds/default/did_web/registry.py +++ b/aries_cloudagent/anoncreds/default/did_web/registry.py @@ -1,6 +1,6 @@ """DID Web Registry.""" import re -from typing import Optional, Pattern, Sequence, Tuple +from typing import Optional, Pattern, Sequence from ....config.injection_context import InjectionContext from ....core.profile import Profile @@ -93,12 +93,6 @@ async def get_revocation_list( """Get a revocation list from the registry.""" raise NotImplementedError() - async def get_revocation_registry_delta( - self, profile: Profile, rev_reg_def_id: str, timestamp: None - ) -> Tuple[dict, int]: - """Get a revocation registry delta.""" - raise NotImplementedError() - async def register_revocation_list( self, profile: Profile,