-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ledger error when registering nym after multi-ledger switch #2496
Conversation
shaangill025
commented
Sep 19, 2023
- resolve Ledger error when completing txn with multiledger enabled #2473
Kudos, SonarCloud Quality Gate passed! |
Built an Askar only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, however I'd ask someone else (@usingtechnology maybe?) to take a quick pass and approve since I am not as deep in the code and might have missed something (and don;t have the power to approve "for real" anyway 🙂 ).
same for me @esune. code makes sense and looks ok to me. can we get someone from the traction team to attempt reproducing this error using this code? something like this in poetry...
|
@shaangill025 mentioned he is still getting an error during stand-up this morning so we might want to wait for an update from him regarding further testing |
ee67a59
to
5ee8dc7
Compare
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
5ee8dc7
to
d9d2513
Compare
Kudos, SonarCloud Quality Gate passed! |
OBE -- this continues to be an issue that we want to address but will probably need to start fresh. |