Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario test with anoncreds wallet upgrade and restart #3410

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Dec 18, 2024

Also a bit of refactoring ...

Alice (issuer - askar) issues 2 credentials and revokes 1 to each of 3 holders (2 askar and 1 anoncreds).

The revocation registry size is set to 5 to ensure there will be a full registry.

Alice and one of the askar holders are then upgraded to anoncreds wallets.

@ianco ianco requested review from dbluhm and jamshale December 18, 2024 22:07
@jamshale
Copy link
Contributor

Looks good 👍 Happy to have this scenario tested better.

@ianco ianco marked this pull request as ready for review December 19, 2024 19:33
container = client.containers.get(container_id)
print((container.name, container.status))
for _ in range(attempts):
if (is_healthy and healthy(container)) or unhealthy(container):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gotta ask... "healthy" or "unhealthy" is fine??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"unhealthy" means we're shutting down the agent and we're checking that it's actually down (we let it shutdown cleanly).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good 👍This is what I was hoping for. Such a useful testing tool to have.

Only thing I'm not sure about is if the credentials actual revocation status is being tested after the upgrade. I remember being a bit concerned that the indexing would line up and the revocation size was identical. I can't remember exactly. There was an issue with this at one point that got fixed.

@ianco
Copy link
Contributor Author

ianco commented Dec 20, 2024

Only thing I'm not sure about is if the credentials actual revocation status is being tested after the upgrade.

Good point, I'll add some more post-upgrade testing to confirm everything is upgraded properly (for both issuer and holder).

@ianco ianco marked this pull request as draft December 20, 2024 17:25
@ianco ianco marked this pull request as ready for review December 20, 2024 17:51
@ianco ianco enabled auto-merge (squash) December 20, 2024 17:51
@ianco ianco merged commit efe14c7 into openwallet-foundation:main Dec 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants