Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump hyperledger/aries-cloudagent-python from py3.9-0.12.2 to py3.9-0.12.3 in /demo/docker-agent #3419

Merged
merged 2 commits into from
Dec 28, 2024
Merged

chore(deps): Bump hyperledger/aries-cloudagent-python from py3.9-0.12.2 to py3.9-0.12.3 in /demo/docker-agent #3419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f571d41
chore(deps): Bump hyperledger/aries-cloudagent-python
dependabot[bot] Dec 23, 2024
7a7a06a
Merge branch 'main' into dependabot/docker/demo/docker-agent/hyperled…
swcurran Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/docker-agent/Dockerfile.acapy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ghcr.io/hyperledger/aries-cloudagent-python:py3.9-0.12.2
FROM ghcr.io/hyperledger/aries-cloudagent-python:py3.9-0.12.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamshale -- should I be updating these as part of a release PR? Easy to do if that should be done...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are 0.12.x — shouldn’t these references be the 1.x?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. These should get upgraded. I'm not exactly sure what this image is for. I think it's just the base image for the demo which still gets all the local src code copied into it. Really it's just being used as a python 3.12 image so it's not a big deal.

The best would be for a follow up PR to update all these images in the repo after the image has been published. We can't do it as the release process because they aren't available yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it depends if the Dockerfiles are used in tests or not. If not used in tests, we could do them with the updates.

Maybe we change them to use the python and not ACA-Py, if everything is being copied in?

USER root

Expand Down
Loading