Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Simplify migration checks #111

Open
nemesifier opened this issue May 20, 2020 · 2 comments
Open

[qa] Simplify migration checks #111

nemesifier opened this issue May 20, 2020 · 2 comments
Labels
Hacktoberfest Easy issues for attracting Hacktoberfest participants.

Comments

@nemesifier
Copy link
Member

nemesifier commented May 20, 2020

We currently have two migration checks:

  • one checks whether there are pending migrations to create (./manage.py makemigrations --dry-run)
  • one checks whether the names of the migration files have auto in them

The problem is that we have to specify both --migration-module and --migration-path.
I think we can avoid doing this and have only one command line flag.

I would get rid of --migration-path, keeping only --migration-module, although I would rename this flag to --migration-modules while keeping backward compatibility with the old flag.

--migration-path should be ignored (printing a deprecation warning).

We will need to upgrade the modules using this: https://github.com/search?q=org%3Aopenwisp+%27--migration-path%27&type=Code

@nemesifier nemesifier added the GCI label May 20, 2020
@nemesifier
Copy link
Member Author

@atb00ker @ppabcd do you see any issues in this?

@atb00ker
Copy link
Member

I don't see an issues, all migrations are in the migrations/ folder and the script can look for that folder name to find the migrations! 😄

@atb00ker atb00ker added the Hacktoberfest Easy issues for attracting Hacktoberfest participants. label Sep 23, 2020
@atb00ker atb00ker removed the GCI label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
None yet
Development

No branches or pull requests

2 participants