Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation for Apache Thrift #1423

Open
Yunie9 opened this issue Mar 7, 2024 · 1 comment
Open

Instrumentation for Apache Thrift #1423

Yunie9 opened this issue Mar 7, 2024 · 1 comment

Comments

@Yunie9
Copy link

Yunie9 commented Mar 7, 2024

Are there plans to support Thrift RPC?Dubbo and gRPC is currently supported.

@codefromthecrypt
Copy link
Member

instrumentation is only added once folks ask for it, and someone has time to implement it. Sometimes, not everything ends up here.. For example, it could be that thrift ends up with a brave module vs us having a thrift one.

The closest we have to thrift instrumentation right now is Armeria, which accepts the thrift protocol. In their case, due to API breaks between thrift versions, they end up needing to a different module per version of thrift. That is an unfortunate norm in libraries that don't ever release a semantic 1.0 version.

There's also a possibility someone has instrumented thrift, just not here. The next step is to get at least a few people interested as there is a maintenance cost for sure. Also, maybe check if someone at thrift is interested in hosting this or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants