Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing logging impl configuration from brave-tests #1441

Open
iparadiso opened this issue Jul 23, 2024 · 0 comments
Open

Consider removing logging impl configuration from brave-tests #1441

iparadiso opened this issue Jul 23, 2024 · 0 comments
Labels

Comments

@iparadiso
Copy link

Describe the Bug

This isn't necessarily a bug, but rather an integration issue. We have a spring boot application that has on brave-tests on the test classpath. This module has a log4j2.properties, which is picked up by spring and caused some logging corruption between tests running in parallel on the same JVM. Removing this dependency resolved the issue.

We generally don't expect libraries to come with their own logging configuration opinions and to let the applications provide those opinions. Libraries should just use SLF4j API and let the application provide the impl and configuration.

Would you consider removing this log4j configuration from the library? Is it actually needed?

@iparadiso iparadiso added the bug label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant