Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Documenting quoting #109

Open
johalnes opened this issue Oct 16, 2023 · 1 comment
Open

[Feature] Documenting quoting #109

johalnes opened this issue Oct 16, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@johalnes
Copy link

Describe the Feature

Hi,

Not really a feature, but suggestion for improving the documentation or readme.

I had big trouble with the error message table already exists. In the logs it stood that no intermediate or backup relation was found, and therefore not deleted.

After quite a lot of searching I found that quoting also is an issue with Oracle. And found that in the test project in this repository you specify the following in the dbt_project file:

quoting:
  database: false
  schema: false
  identifier: false

This solved all of my trouble. Maybe this should be suggested at either the installation page on dbt adapter page or at the beginning of the readme file?

Describe alternatives you've considered

On Snowflake they have changed the defaults:
image

Could be an idea if this is recommended for all users of Oracle?

Who will this benefit?

No response

Anything else?

No response

@johalnes johalnes added the enhancement New feature or request label Oct 16, 2023
@aosingh
Copy link
Member

aosingh commented Oct 16, 2023

@johalnes Thank you for reporting this issue. Sorry that you had to go through the trouble. We want to make dbt-oracle simple and easy. I can update the documentation.

Default quoting parameters are all False. Did you have any quoting options enabled before ?
is this an on-prem database ? I need this information to update documentation for different Database (on-prem, cloud, etc)

@aosingh aosingh self-assigned this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants