Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

water everywhere in some tiles #1006

Open
wurtzj opened this issue Nov 15, 2024 · 6 comments
Open

water everywhere in some tiles #1006

wurtzj opened this issue Nov 15, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@wurtzj
Copy link

wurtzj commented Nov 15, 2024

Hello,

It seems there is an error in Geoclimate when defining some water RSU.
I am doing bounding boxes all around Europe and in some cases I get water nearly everywhere.
It seems to me that the issue could be related to the definition or the proper closure of the RSU.

Here is a tile exemple with this issue,

latitude : 55.8 - 56
longitude : -3.6 - -3.4

image

This figure shows the result of geoclimate rasterized. But the raw vector data depicts the same issue.
In purple WATER=0, in yellow WATER=1.

Thank you for your help,

Kind Regards,

Jean

@j3r3m1
Copy link
Collaborator

j3r3m1 commented Nov 17, 2024

I have identified very close cases where one is working and the other has the bug identified.

Below are the two config files:
A minimum example with the error

{
    "description": "Processing OSM data",
    "input": {
    	"area" : 100000,
    	"timeout": 9000,
	"maxsize":4294967296,
        "locations": [
            [55.995,-3.56, 56, -3.4]
        ]
    },
    "output": {
        "folder": "/tmp"
    },
    "parameters": {
        "rsu_indicators": {
            "indicatorUse": [
                "LCZ",
                "TEB"
            ],
            "svfSimplified": true,
            "estimateHeight": true
        }
    }
}

A minimum example without error

{
    "description": "Processing OSM data",
    "input": {
    	"area" : 100000,
    	"timeout": 9000,
	"maxsize":4294967296,
        "locations": [
            [55.995,-3.555, 56, -3.4]
        ]
    },
    "output": {
        "folder": "/tmp"
    },
    "parameters": {
        "rsu_indicators": {
            "indicatorUse": [
                "LCZ",
                "TEB"
            ],
            "svfSimplified": true,
            "estimateHeight": true
        }
    }
}

To @ebocher as you can see there is a quite narrow strip of land which is causing the error but I have not identified which geographical feature may be the cause of the problem. Any idea ?

@wurtzj
Copy link
Author

wurtzj commented Nov 18, 2024

Hello all,

Here is an other example near the coast where coast and land seems reversed.

Thanks,
Capture d’écran_2024-11-18_13-38-24

@j3r3m1
Copy link
Collaborator

j3r3m1 commented Nov 18, 2024

Can you share the coordinates ?

@ebocher
Copy link
Member

ebocher commented Nov 18, 2024

Step-by-step investigations are necessary.

@ebocher ebocher added the bug Something isn't working label Nov 18, 2024
@wurtzj
Copy link
Author

wurtzj commented Nov 18, 2024

Here there are :

Longitude 15,6E - 16E
Latitude 68,4N - 68,6N

I was making 0.2x0.2° tiles, but it seems the bug here is on two tiles.

@j3r3m1
Copy link
Collaborator

j3r3m1 commented Nov 28, 2024

I have tried with older versions of GeoClimate, none of the ones I have from 2023-10 works. This is a quite a good news since it means new versions do not add new issues.

@ebocher ebocher self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants