-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing buildings using GeoClimate Tools #997
Comments
Hi @sachabaclet Please share the json file you are using with GeoClimate so we can debugg it. Thanks |
Here is the geojson file generated by GeoClimate Tools: |
Oupsss I mean the GeoClimate json config file. |
I am using the tool by Samuel Marsault, so this may be what you are looking for: |
Thank you for reporting. Here are the reasons:
|
Hello @j3r3m1, I think tents should not be added for the moment has it has no thermal inertia, even if it is impervious (which will be considered as road in meteorological models). |
Hello @wurtzj , For the acoustic use of geoclimate is important to use every buildings... Maybe a option could be added ? Best |
Maybe it could be added in an additional class ? TENT_FRACTION ? |
Oww sorry I didn't see it was about tents ! ... I read too fast. For acoustic use, the tent may not be in extracted buildings ! |
Good job inspecteur @j3r3m1 ! |
Do you have test cases where you observed or suppose it might be missing ? Because it should normally work if the building has the key:value "building:warehouse" (cf. https://github.com/orbisgis/geoclimate/blob/master/osm/src/main/resources/org/orbisgis/geoclimate/osm/buildingParams.json) |
Not sure I understand the issue. Is the building fraction too low or the fraction of warehouse building ? Because most of the building do not have a tag then they get the tag of the area they are located in (which is industrial). Then there should be a large proportion of industrial buildings I suppose |
Yes to me building fraction is underestimated. |
Ok good to know. I think it is a cognitive bias from my side then. |
I am going to test if we get all buildings from the zone anyway, we might have forgotten some tags (I know understand that it was your initial question...), do not close it yet. |
We might think that there are several missing buildings in the area (cf. below) But actually most of the polygons that look like buildings are construction zones or brownfields and their color is slightly different than the buidings. There is a single building that is missing and need to be added but it is tiny (https://www.openstreetmap.org/way/796915590). |
Thanks for checking ! :) |
Hi,
I have used
GeoClimate_Tools-1.0.1
to extract the buildings in the city of Tartu (Estonia). However, I noticed that some buildings were missing from the outputbuilding.geojson
file.You can see in the following image the buildings extracted by the tools in pink and the missing buildings in blue.
The text was updated successfully, but these errors were encountered: