You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for this, great work as always ✌️
I just wanted to check if there was any specific reasoning in choosing warn over message for the New dependencies added... message?
It might feel odd for some user (especially newcomers) as danger then also says ⚠️ Danger found some issues. Don't worry, everything is fixable. in the github status pane, making it sound like an error that needs to be fixed.
🤔
The text was updated successfully, but these errors were encountered:
Hello 👋 - IMO, a warning is a "you should definitely check this out" and I think the introduction of any new dependency (in any project) warrants a close investigation from reviewers.
Though I do agree with the sentiment that it provides a more negative re-enforcement than I'd probably like. I'm fine with this switching to message 👍
Hey @orta!
Thanks for this, great work as always ✌️
I just wanted to check if there was any specific reasoning in choosing
warn
overmessage
for theNew dependencies added...
message?It might feel odd for some user (especially newcomers) as danger then also says
⚠️ Danger found some issues. Don't worry, everything is fixable.
in the github status pane, making it sound like an error that needs to be fixed.🤔
The text was updated successfully, but these errors were encountered: