Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dependency as a warning #2

Open
fwal opened this issue Jul 7, 2017 · 1 comment
Open

New dependency as a warning #2

fwal opened this issue Jul 7, 2017 · 1 comment

Comments

@fwal
Copy link
Contributor

fwal commented Jul 7, 2017

Hey @orta!

Thanks for this, great work as always ✌️
I just wanted to check if there was any specific reasoning in choosing warn over message for the New dependencies added... message?

It might feel odd for some user (especially newcomers) as danger then also says ⚠️ Danger found some issues. Don't worry, everything is fixable. in the github status pane, making it sound like an error that needs to be fixed.

🤔

@orta
Copy link
Owner

orta commented Jul 7, 2017

Hello 👋 - IMO, a warning is a "you should definitely check this out" and I think the introduction of any new dependency (in any project) warrants a close investigation from reviewers.

Though I do agree with the sentiment that it provides a more negative re-enforcement than I'd probably like. I'm fine with this switching to message 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants