Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot auto confirm the social sign in prompt on tunnel run #219

Open
6 tasks done
Benehiko opened this issue Sep 23, 2022 · 3 comments
Open
6 tasks done

Cannot auto confirm the social sign in prompt on tunnel run #219

Benehiko opened this issue Sep 23, 2022 · 3 comments
Labels
bug Something is not working.

Comments

@Benehiko
Copy link
Contributor

Preflight checklist

Describe the bug

The Ory tunnel will now prompt the user about using the social sign in option like so:

ory tunnel http://localhost:3000 --project <slug> --dev
To support complex flows such as Social Sign In, the Ory CLI can configure your project automatically. To do so, you need to be signed in. Do you want to sign in? [y/n]:

When using the flag --yes or -y on the command it doesn't confirm it and continue.

Reproducing the bug

Run ory tunnel for the first time and the prompt will appear. Try skip it by adding the --yes flag:

ory tunnel http://localhost:3000 --project optimistic-turing-6cxufsm48m --dev --yes
To support complex flows such as Social Sign In, the Ory CLI can configure your project automatically. To do so, you need to be signed in. Do you want to sign in? [y/n]:

Relevant log output

No response

Relevant configuration

No response

Version

v0.1.41

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Ory Cloud

Additional Context

Reported on slack:
https://ory-community.slack.com/archives/C010F7Z4XM1/p1663858573933829

Right now a workaround could be for the user to pipe in the confirmation themselves:

sh -c "yes | ory tunnel http://localhost:3000/ --project <project-slug> --dev"
@Benehiko Benehiko added the bug Something is not working. label Sep 23, 2022
@aeneasr
Copy link
Member

aeneasr commented Oct 4, 2022

ory tunnel http://localhost:3000/ --project <project-slug> --quiet will do the trick.

@Benehiko
Copy link
Contributor Author

Benehiko commented Oct 5, 2022

Okay nice. Shouldn't we maybe update the cli to be more descriptive?

For instance when running:

~ ory tunnel -h
...

Flags:
      --allowed-cors-origins strings   A list of allowed CORS origins. Wildcards are allowed.
  -c, --config string                  Path to the Ory Cloud configuration file.
      --cookie-domain string           Set a dedicated cookie domain.
      --debug                          Use this flag to debug, for example, CORS requests.
      --default-redirect-url string    Set the URL to redirect to per default after e.g. login or account creation.
      --dev                            Use this flag when developing locally.
  -h, --help                           help for tunnel
      --port int                       The port the proxy should listen on. (default 4000)
      --project string                 The slug of your Ory Cloud Project.
  -q, --quiet                          Be quiet with output printing.
  -y, --yes                            Confirm all dialogs with yes.

We can se the -q or --quiet flag there, but it just says it won't be printing output. In this case I would assume the -y or --yes flag to be the one confirming if I want social sign in for example.

@aeneasr
Copy link
Member

aeneasr commented Oct 5, 2022

Yeah true, we should update the description a bit. Something like "Surpresses all dialogues and answers with the default". Contribs welcomed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants