Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user defined client IDs #155

Open
4 of 5 tasks
tokongs opened this issue Oct 29, 2024 · 2 comments
Open
4 of 5 tasks

Allow user defined client IDs #155

tokongs opened this issue Oct 29, 2024 · 2 comments
Labels
feat New feature or request.

Comments

@tokongs
Copy link

tokongs commented Oct 29, 2024

Preflight checklist

Ory Network Project

No response

Describe your problem

When creating a Oauth2Client with an secret that contains a predefined CLIENT_ID. The reconciliation errors out because it's unable to find a client with that ID.

Describe your ideal solution

A client with the provided ID is created.

Workarounds or alternatives

None

Version

0.34.0

Additional Context

No response

@tokongs tokongs added the feat New feature or request. label Oct 29, 2024
@ariep
Copy link

ariep commented Dec 17, 2024

I can confirm this, and I'd like to add that this is a regression because this used to work with older versions of hydra-maester. We're relying on this behaviour to have predictable client IDs and secrets that we can set using our provisioning system, so this change in behaviour is preventing us from upgrading hydra.

@ariep
Copy link

ariep commented Dec 17, 2024

From a quick reading, this seems to be the commit that introduced this change:
2a6cef5#diff-1c66e5dad42957f87587a8ad18d9815b912a40e6bbacb41d64be576d56a92750R204

Oh I think this is a duplicate of #117 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants