Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color button issue #10

Open
Rutorai opened this issue Apr 30, 2020 · 2 comments
Open

Background color button issue #10

Rutorai opened this issue Apr 30, 2020 · 2 comments
Assignees

Comments

@Rutorai
Copy link
Contributor

Rutorai commented Apr 30, 2020

Hello,

The queryCommandValue doesn't work with firefox (at least version 75.0 (64-bit) on linux). It always returns 'transparent'. So button color is not updated according to the backgroung color of the selected text.

It seems to be a issue with firefox for a long time.

Regards.

@andersevenrud
Copy link
Member

I see. The simplest way is probably just to ignore the transparent value in the function that detects this, that way it defaults to white at least.

@Rutorai
Copy link
Contributor Author

Rutorai commented Apr 30, 2020

I think it's not really bad to let the code as is. Finally, it works. But if one day firefox fix the bug ... or try another solution : with getSelection and css style. I found some workaround like that.

@andersevenrud andersevenrud self-assigned this Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants