Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOETA: Support HTTP API to kickoff stream #174

Open
winlinvip opened this issue Apr 18, 2024 · 3 comments · May be fixed by #210
Open

NOETA: Support HTTP API to kickoff stream #174

winlinvip opened this issue Apr 18, 2024 · 3 comments · May be fixed by #210
Assignees
@winlinvip
Labels
EnglishNative This issue is conveyed exclusively in English.

Comments

@winlinvip
Copy link
Member

You can directly call SRS HTTP API, via SRS Stack:

curl -v -X DELETE https://test.com/api/v1/clients/id

However, it can only operate based on ID. Meanwhile, SRS Stack enables operation according to stream names or room names.

For George

Support in v5.14.16, API: Support kickoff stream by name. v5.14.16

  • /terraform/v1/mgmt/streams/query Query the active streams.
  • /terraform/v1/mgmt/streams/kickoff Kickoff the stream by name.
@winlinvip winlinvip converted this from a draft issue Apr 18, 2024
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Apr 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Oryx Roadmap Apr 18, 2024
@starriesWEB
Copy link

  • Now /terraform/v1/mgmt/streams/kickoff supports name query
  • But /terraform/v1/mgmt/streams/query does not support name query

The business side implements signaling by itself and needs to determine the existence of the stream by name

oryx/platform/service.go

Line 1562 in 77e6ee8

ep := "/terraform/v1/mgmt/streams/query"

oryx/platform/service.go

Line 1612 in 77e6ee8

ep := "/terraform/v1/mgmt/streams/kickoff"

@winlinvip
Copy link
Member Author

Make sense. Need to support /query filter by names.

@winlinvip winlinvip reopened this Aug 15, 2024
@winlinvip winlinvip self-assigned this Aug 15, 2024
@winlinvip winlinvip moved this from ✅ Done to 📋 Backlog in Oryx Roadmap Aug 15, 2024
@winlinvip winlinvip changed the title Support HTTP API to kickoff stream NOETA: Support HTTP API to kickoff stream Aug 15, 2024
@starriesWEB starriesWEB linked a pull request Aug 16, 2024 that will close this issue
Open
@starriesWEB
Copy link

Make sense. Need to support /query filter by names.

I submitted a PR. You can take a look if you have time.
#210

@winlinvip winlinvip linked a pull request Aug 18, 2024 that will close this issue
support streams/query with params #210
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
Oryx Roadmap
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support streams/query with params starriesWEB/oryx
2 participants
@winlinvip @starriesWEB