Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell fix: visable -> visible #17

Open
plajjan opened this issue Mar 5, 2017 · 1 comment
Open

Spell fix: visable -> visible #17

plajjan opened this issue Mar 5, 2017 · 1 comment

Comments

@plajjan
Copy link

plajjan commented Mar 5, 2017

"visible" is spelled incorrectly in a number of places in the source. Since it's also part of the JSON data being loaded we might want to consider accepting both 'visable' and 'visible', at least over some time, for background compatibility.

@otm
Copy link
Owner

otm commented Mar 6, 2017

That is probably a good idea. The cleanest way forward is change 'visable' to 'visible' everywhere in the code and add decorator to the Graph.load function that changes 'visable' to 'visible'.

I can probably do the code change fairly quickly, but testing will take a bit of time as they are lacking, to say at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants