Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Discounts/pricing may not be calculated correctly - needs thorough QA #75

Open
jmimico opened this issue Dec 17, 2019 · 0 comments
Labels
bug Something isn't working major High Priority

Comments

@jmimico
Copy link

jmimico commented Dec 17, 2019

In production we sometimes have to provide credits for downtime of service. We do this by editing 'default.py' in the billing api.

Example:
{
'period_start': '2018-05-25',
'period_end': '2019-04-01',
'cpu_price': 0.03,
'volume_price': 0.000067,
'image_price': 0.000067
},
{
'period_start': '2019-04-02',
'period_end': '2019-04-03',
'cpu_price': 0,
'volume_price': 0,
'image_price': 0
},
{
'period_start': '2019-04-04',
'period_end': '2019-11-01',
'cpu_price': 0.03,
'volume_price': 0.000067,
'image_price': 0.000067
},

OR

{
    'period_start': '2019-04-04',
    'period_end': '2019-11-01',
    'cpu_price': 0.03,
    'volume_price': 0.000067,
    'image_price': 0.000067
},
{
    'period_start': '2019-11-01',
    'period_end': '2019-11-02',
    'cpu_price': 0.02,
    'volume_price': 0.000044,
    'image_price': 0.000044
},
{
    'period_start': '2019-11-02',
    'period_end': '2019-11-07',
    'cpu_price': 0.03,
    'volume_price': 0.000067,
    'image_price': 0.000067
},
{
    'period_start': '2019-11-07',
    'period_end': '2019-11-08',
    'cpu_price': 0.015,
    'volume_price': 0.0000335,
    'image_price': 0.0000335
},
{
    'period_start': '2019-11-08',
    'period_end': '2019-11-15',
    'cpu_price': 0.03,
    'volume_price': 0.000067,
    'image_price': 0.000067
},
{
    'period_start': '2019-11-15',
    'period_end': '2019-11-16',
    'cpu_price': 0.015,
    'volume_price': 0.0000335,
    'image_price': 0.0000335
},
{
    'period_start': '2019-11-16',
    'period_end': '2020-12-31',
    'cpu_price': 0.03,
    'volume_price': 0.000067,
    'image_price': 0.000067
}

After reviewing the invoices I am not confident that the discounts are always configured correctly. I am asking that

  1. Some QA be performed to the discounts
  2. A friendlier way to apply discounts be made
@jmimico jmimico added the bug Something isn't working label Dec 17, 2019
@rosibaj rosibaj added major High Priority and removed Priority: High labels Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major High Priority
Projects
None yet
Development

No branches or pull requests

3 participants